Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orchestration): field alias should represent the isList in the result #5449

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

adrien2p
Copy link
Member

What
When using fieldAlias, we loose the isList configuration. This pr aims to include that behaviour while using a fieldAlias

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

🦋 Changeset detected

Latest commit: 57421de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/orchestration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 2:27pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 2:27pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 2:27pm

@adrien2p
Copy link
Member Author

@carlos-r-l-rodrigues could you have a look at this one. We can discuss it :)

@adrien2p adrien2p marked this pull request as ready for review October 23, 2023 14:07
@adrien2p adrien2p requested a review from a team as a code owner October 23, 2023 14:07
@adrien2p adrien2p requested review from fPolic and olivermrbl October 23, 2023 14:07
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/orchestration/src/joiner/remote-joiner.ts Outdated Show resolved Hide resolved
Co-authored-by: Oli Juhl <59018053+olivermrbl@users.noreply.github.com>
@olivermrbl olivermrbl merged commit 5c77029 into develop Oct 23, 2023
@olivermrbl olivermrbl deleted the fix/remote-query-fieldsAlias-isList branch October 23, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants