Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-ui): sorted and added the espanol translations #5461

Conversation

prajjwalkumar17
Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 commented Oct 24, 2023

##Description

-> Español translation correction and sorting for Admin UI

Resolves: #5346

@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner October 24, 2023 15:56
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

⚠️ No Changeset found

Latest commit: b18916a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2023

@prajjwalkumar17 is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@VariableVic VariableVic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prajjwalkumar17
Copy link
Contributor Author

Hey @VariableVic can you please add the Hacktoberfest label as don't know why this isn't getting accepted as a hactoberfest PR

@VariableVic
Copy link
Contributor

Hey @VariableVic can you please add the Hacktoberfest label as don't know why this isn't getting accepted as a hactoberfest PR

@prajjwalkumar17 done, let me know if that works! I think it should count as soon as it's merged.

@prajjwalkumar17
Copy link
Contributor Author

Hey @VariableVic can you please add the Hacktoberfest label as don't know why this isn't getting accepted as a hactoberfest PR

@prajjwalkumar17 done, let me know if that works! I think it should count as soon as it's merged.

Not yet I hope it will be done once it gets merged

@prajjwalkumar17
Copy link
Contributor Author

Can you add The Hacktoberfest-accepted label as that insures it getting added to the selected contributions :)

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 9:13am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 9:13am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 9:13am

@olivermrbl
Copy link
Contributor

We are reworking how translations in admin are handled, so this will not be merged. However, we appreciate the contribution. Keep an eye out for our upcoming releases to know more about this update, and if you are still interested, we'd love to see a new PR then :)

@olivermrbl olivermrbl closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hacktoberfest request: Add translations to Admin
3 participants