Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-ui): add Tamil translation #5463

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

prajjwalkumar17
Copy link
Contributor

##Description

-> Tamil translation Admin UI.

Resolves: #5346

@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner October 24, 2023 18:46
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

⚠️ No Changeset found

Latest commit: afa0629

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2023

@prajjwalkumar17 is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@VariableVic VariableVic changed the title feat(admin-ui): added translations for tamil language feat(admin-ui): add Tamil translation Oct 26, 2023
Copy link
Contributor

@VariableVic VariableVic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your language to the supportedLanguages array in packages/admin-ui/ui/src/i18n/index.ts

@prajjwalkumar17
Copy link
Contributor Author

I have added it please have a look @VariableVic

Copy link
Contributor

@VariableVic VariableVic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:48pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:48pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:48pm

@olivermrbl olivermrbl merged commit ec2b841 into medusajs:develop Oct 26, 2023
12 checks passed
@prajjwalkumar17
Copy link
Contributor Author

Don't know why but it shows not accepted in hactoberfest :) my second pr as well can i make more pr ?

@VariableVic
Copy link
Contributor

VariableVic commented Oct 26, 2023

Don't know why but it shows not accepted in hactoberfest :) my second pr as well can i make more pr ?

That's weird, might take some time? Or do you get some error message? I've added the hacktoberfest-accepted label, lmk if that works.

@prajjwalkumar17
Copy link
Contributor Author

Yeah it just came can you please add this label in this PR as well thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hacktoberfest request: Add translations to Admin
3 participants