Feat(authentication): username password provider #6052
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
pKorsholm
force-pushed
the
feat/authentication-provider-username-password
branch
from
cd1a28d to
c9c22a4
Compare
pKorsholm
changed the base branch from
develop
to
feat/run-onapplicationstart
| if(service.__hooks?.onApplicationStart) { | ||
| await service.__hooks.onApplicationStart() | ||
| } |
There was a problem hiding this comment.
todo: I would suggest to start using the medusa app to start modules. you can see how we achieved that in the search pr https://github.com/medusajs/medusa/blob/7de35d84c889070f34dd18255000bb39fba06a72/packages/medusa-test-utils/src/init-modules.ts
There was a problem hiding this comment.
I am not super happy about these service hooks. The consumer of a module service should never have to worry about the providers being created on load - even when using initialize.
However, this concern can be discussed and tackled separately from this PR.
There was a problem hiding this comment.
This is needed for modules that require something to be executed after all modules are loaded and the application is running.
It was originally created at the index/search module where it reads all the exported joiner configs of loaded modules.
This is not executed by the consumer of the modules. MedusaApp calls it after it has completed loading everything.
There was a problem hiding this comment.
As we discussed a few times, at some point we need to normalize all entrypoints to be MedusaApp, and discourage the use of initialize directly
| if (password_hash && typeof password_hash === "string") { | ||
| const buf = Buffer.from(password_hash, "base64") | ||
|
|
||
| const success = await Scrypt.verify(buf, password) |
There was a problem hiding this comment.
suggestion: experiment running that with worker_threads (it doesn't have to be in this PR)
pKorsholm
changed the base branch from
feat/run-onapplicationstart
to
develop
pKorsholm
force-pushed
the
feat/authentication-provider-username-password
branch
from
b57fde1 to
5bf05cc
Compare
| provider: provider.PROVIDER, | ||
| name: provider.DISPLAY_NAME, | ||
| }) | ||
| function asArray( |
There was a problem hiding this comment.
question: Seems off to place a generic util like this here
| @@ -0,0 +1,15 @@ | |||
| import { Migration } from '@mikro-orm/migrations'; | |||
There was a problem hiding this comment.
comment: You should be able to omit the migration entirely until we have finalized the module. The tests will read the models and do not depend on migration files.
|
|
||
| type OptionalFields = "provider_metadata" | "app_metadata" | "user_metadata" | ||
|
|
||
| @Entity() | ||
| @Unique({ properties: ["provider","entity_id" ], name: "IDX_auth_user_provider_entity_id" }) |
There was a problem hiding this comment.
question: Does this need linting?
No description provided.