Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cart): Line items operations #6066

Merged
merged 15 commits into from
Jan 16, 2024
Merged

feat(cart): Line items operations #6066

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
120458b
items ops
olivermrbl Jan 11, 2024
d9c0666
resolve conflicts
olivermrbl Jan 12, 2024
61e3a1b
change test script
olivermrbl Jan 12, 2024
adfefb3
update signatures
olivermrbl Jan 13, 2024
d905e0c
add missing context
olivermrbl Jan 15, 2024
3eab5e0
fix tests
olivermrbl Jan 15, 2024
b7290e5
fix
olivermrbl Jan 15, 2024
ad51b61
finally settle on API
olivermrbl Jan 15, 2024
e2c9b17
address PR comments
olivermrbl Jan 16, 2024
56b996d
resolve conflicts
olivermrbl Jan 16, 2024
011aa91
resolve conflicts
olivermrbl Jan 16, 2024
2f51e82
address feedback
olivermrbl Jan 16, 2024
7410b59
add context decorators
olivermrbl Jan 16, 2024
9ce8990
address comments
olivermrbl Jan 16, 2024
a709906
fix signatures
olivermrbl Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/cart/src/services/cart-module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,10 +272,11 @@ export default class CartModuleService implements ICartModuleService {
| string
| CartTypes.CreateLineItemForCartDTO[]
| CartTypes.CreateLineItemForCartDTO,
dataOrSharedContext?:
@MedusaContext()
olivermrbl marked this conversation as resolved.
Show resolved Hide resolved
dataOrSharedContext:
olivermrbl marked this conversation as resolved.
Show resolved Hide resolved
| CartTypes.CreateLineItemDTO[]
| CartTypes.CreateLineItemDTO
| Context,
| Context = {},
@MedusaContext() sharedContext: Context = {}
): Promise<CartTypes.CartLineItemDTO[] | CartTypes.CartLineItemDTO> {
let items: LineItem[] = []
Expand Down Expand Up @@ -345,12 +346,12 @@ export default class CartModuleService implements ICartModuleService {
| string
| CartTypes.UpdateLineItemWithSelectorDTO[]
| Partial<CartTypes.CartLineItemDTO>,
@MedusaContext()
olivermrbl marked this conversation as resolved.
Show resolved Hide resolved
dataOrSharedContext:
| CartTypes.UpdateLineItemDTO
| Partial<CartTypes.UpdateLineItemDTO>
| Context = {},
@MedusaContext()
sharedContext: Context = {}
@MedusaContext() sharedContext: Context = {}
): Promise<CartTypes.CartLineItemDTO[] | CartTypes.CartLineItemDTO> {
let items: LineItem[] = []
if (isString(lineItemIdOrDataOrSelector)) {
Expand All @@ -377,7 +378,7 @@ export default class CartModuleService implements ICartModuleService {
} as CartTypes.UpdateLineItemWithSelectorDTO,
]

items = await this.updateLineItemsWithSelector(
items = await this.updateLineItemsWithSelector_(
toUpdate,
dataOrSharedContext as Context
olivermrbl marked this conversation as resolved.
Show resolved Hide resolved
)
Expand Down Expand Up @@ -405,7 +406,7 @@ export default class CartModuleService implements ICartModuleService {
}

@InjectTransactionManager("baseRepository_")
protected async updateLineItemsWithSelector(
protected async updateLineItemsWithSelector_(
updates: CartTypes.UpdateLineItemWithSelectorDTO[],
@MedusaContext() sharedContext: Context = {}
): Promise<LineItem[]> {
Expand Down
Loading