-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cart): Line items operations #6066
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
76545b1
to
64426a1
Compare
64426a1
to
ad51b61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you update all the joiner-config file reflecting all the entities when the module is done?
@carlos-r-l-rodrigues, yes – my idea was to add all the "configurational" bits and pieces as well as the migration in the end to avoid having to re-review it numerous times as things change. OK with you? |
I think it is ok. I quite like the incremental implementation approach you have used so far. But indeed, we should not forget some part in the end. Maybe when doing this approach we should have a check list of what should be included in the module development process. Cause it is nice to have smaller reviews, but it is also easy to forget something in between the first and last pr |
23dd46b
to
5ddcdfc
Compare
5ddcdfc
to
e2c9b17
Compare
72a9455
to
2f51e82
Compare
Any final comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM strong work 💪
awaiting #6012What
Add line items
Update line items
Remove line items
The first is a selector-based removal. In this example, we want to remove all line items that have
variant_id=var_1234
. Imagine you accidentally published a product that was not supposed to go live for another two months. The selector-based approach handles this scenario very elegantly.Additionally, the PR comes with tests for all and a few typings updates.