feat(fulfillment): Module service implementation first iteration #6381

adrien2p · 2024-02-12T12:43:54Z

What

Tip

The review should particularly focus on the module service implementation and the integration tests to ensure that the behavior conforms to the expectations. In Sus, the adjustments made to the models and DTO's

Warning

The delete methods are kept aside as it will require manually cascading since according to the doc, cascade remove on collection will perform one query per item. In that case I rather prefer deleting them manually in bulk.

Preliminary migration file
- Does not include changes to be integrated with existing tables from the core, so probably not to review unless for indexes and modules schema expectations
Events will be managed separately later on
Update some indexes and unique indexes
Start implementing the module service with the following
- create - To create fulfillment set including service zones and geo zones
- createServiceZones - To create service zones and geo zones that can be attached to a fulfillment set on update
- update - To update a fulfillment set and allow to replace/add/remove service zones
- updateServiceZones - Update service zones with their geo zones to either attach an existing zones or create a new one or replace existing ones
- create geo zones
- update geo zones
- soft delete are based from the abstraction
- list/retrieve/listAndCount are based from the abstraction
Few adjustments in regards to the DTO's
Integration tests for the above module service

FIXES CORE-1716
FIXES CORE-1734

changeset-bot · 2024-02-12T12:43:58Z

🦋 Changeset detected

Latest commit: 0d8a946

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@medusajs/types	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-02-12T12:44:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
medusa-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 14, 2024 4:53pm

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)		Feb 14, 2024 4:53pm
docs-ui	⬜️ Ignored (Inspect)	Visit Preview	Feb 14, 2024 4:53pm
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview	Feb 14, 2024 4:53pm

…ment set creation

packages/customer/src/migrations/Migration20240124154000.ts

**What** Fix the test utils database to trully run the migrations, the migration path is deprecated and not used anymore as umzung infer the path under the hood. It also fix the schema so that it is possible to specify different schema if needed. The index helper can now create named constraints for uniqueness. extracted [from](#6381)

packages/fulfillment/src/services/fulfillment-module-service.ts

packages/fulfillment/src/migrations/Migration20240213165503.ts

packages/fulfillment/src/services/fulfillment-module-service.ts

srindom

Very nice work - have a few comments on the data model. Might make sense to address as part of this PR, but up to you.

packages/fulfillment/src/models/fullfilment-set.ts

packages/fulfillment/src/services/fulfillment-module-service.ts

packages/fulfillment/src/models/service-zone.ts

…js/medusa into feat/fulfillment-implementation-1

srindom

LGTM!

olivermrbl · 2024-02-14T17:40:19Z

packages/fulfillment/src/models/fullfilment-set.ts

-    inverseJoinColumn: "service_zone_id",
+  @OneToMany(() => ServiceZone, "fulfillment_set", {
+    cascade: [Cascade.PERSIST, "soft-remove"] as any,
+    orphanRemoval: true,


question: I thought we didn't use this because of its "aggressiveness". I am fine to keep it in, but just wanted to point it out in case it was an oversight

Here it a requirements. Because since i am bulk deleting the entities, then when mikro orm manage the collection under the hood it will complain that thos configuration is missing. Also, i am in a case where if the fulfillment set is removed completely, then we can have orphan service zones since the foreign key is non nullable. Same goes between service zones and geo zones

olivermrbl · 2024-02-14T17:40:27Z

packages/fulfillment/src/models/service-zone.ts

-    inverseJoinColumn: "geo_zone_id",
+  @OneToMany(() => GeoZone, "service_zone", {
+    cascade: [Cascade.PERSIST, "soft-remove"] as any,
+    orphanRemoval: true,


olivermrbl · 2024-02-14T17:40:56Z

@adrien2p feel free to merge 🚢

feat(fulfillment): Module sevice implemntation first iteration

a22d873

github-actions bot added the team: medusa label Feb 12, 2024

vercel bot deployed to Preview – medusa-dashboard February 12, 2024 12:47 View deployment

cleanup

1299453

vercel bot deployed to Preview – medusa-dashboard February 12, 2024 12:54 View deployment

adrien2p added 4 commits February 12, 2024 14:19

Create geo zones as part of the service zones creation during fulfill…

a2ba452

…ment set creation

cleanup

e42052b

wrap in a separate describe

baf85d8

rm todo

1fa628c

vercel bot deployed to Preview – medusa-dashboard February 12, 2024 13:26 View deployment

trully run db migrations

dc2d2b5

adrien2p commented Feb 12, 2024

View reviewed changes

packages/customer/src/migrations/Migration20240124154000.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview – medusa-dashboard February 12, 2024 14:45 View deployment

fixes

f52f6a8

vercel bot deployed to Preview – medusa-dashboard February 12, 2024 15:13 View deployment

adrien2p added 2 commits February 12, 2024 16:53

fixes

6050c0f

fixes

00c8ca6

vercel bot deployed to Preview – medusa-dashboard February 12, 2024 15:59 View deployment

adrien2p mentioned this pull request Feb 12, 2024

chore(): Fix database test utils and utils #6383

Merged

continue creation flow

b89cfe8

vercel bot deployed to Preview – medusa-dashboard February 13, 2024 09:08 View deployment

cleanup

9bf0c82

vercel bot deployed to Preview – medusa-dashboard February 13, 2024 09:17 View deployment

resolve conflicts

46111d4

vercel bot deployed to Preview – medusa-dashboard February 13, 2024 09:49 View deployment

Add support to create service zones with geo zones

af47507

vercel bot deployed to Preview – medusa-dashboard February 13, 2024 09:58 View deployment

vercel bot deployed to Preview – medusa-dashboard February 13, 2024 16:58 View deployment

carlos-r-l-rodrigues reviewed Feb 13, 2024

View reviewed changes

packages/fulfillment/src/services/fulfillment-module-service.ts Outdated Show resolved Hide resolved

olivermrbl reviewed Feb 13, 2024

View reviewed changes

srindom reviewed Feb 14, 2024

View reviewed changes

adrien2p added 5 commits February 14, 2024 11:39

Update relationship and create* methods

f1f3c50

finalise rework

479185c

Merge branch 'develop' into feat/fulfillment-implementation-1

51e644f

cleanup

aea52f5

Merge branch 'feat/fulfillment-implementation-1' of github.com:medusa…

e55b72b

…js/medusa into feat/fulfillment-implementation-1

adrien2p requested review from srindom and olivermrbl February 14, 2024 12:38

vercel bot deployed to Preview – medusa-dashboard February 14, 2024 12:42 View deployment

move get set diff

eb775f2

vercel bot deployed to Preview – medusa-dashboard February 14, 2024 12:55 View deployment

adrien2p requested a review from carlos-r-l-rodrigues February 14, 2024 13:16

Merge branch 'develop' into feat/fulfillment-implementation-1

8e53af4

vercel bot deployed to Preview – medusa-dashboard February 14, 2024 13:36 View deployment

Merge branch 'develop' into feat/fulfillment-implementation-1

0d8a946

vercel bot deployed to Preview – medusa-dashboard February 14, 2024 16:53 View deployment

srindom approved these changes Feb 14, 2024

View reviewed changes

olivermrbl approved these changes Feb 14, 2024

View reviewed changes

adrien2p merged commit fafde4f into develop Feb 14, 2024
17 checks passed

This was referenced Feb 14, 2024

Version Packages #6360

Merged

Version Packages MicahBCode/medusa#1

Closed

Version Packages driver005/medusa#1

Open

This was referenced Feb 22, 2024

Version Packages webbersagency/medusa#38

Open

Version Packages SGFGOV/medusa#3

Open

Version Packages wangjue666/medusa#1

Open

github-actions bot mentioned this pull request Mar 7, 2024

Version Packages inicolvs/medusa#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(fulfillment): Module service implementation first iteration #6381

feat(fulfillment): Module service implementation first iteration #6381

adrien2p commented Feb 12, 2024 •

edited

Loading

changeset-bot bot commented Feb 12, 2024 •

edited

Loading

vercel bot commented Feb 12, 2024 •

edited

Loading

srindom left a comment

srindom left a comment

olivermrbl Feb 14, 2024

adrien2p Feb 14, 2024

olivermrbl Feb 14, 2024

olivermrbl commented Feb 14, 2024

feat(fulfillment): Module service implementation first iteration #6381

feat(fulfillment): Module service implementation first iteration #6381

Conversation

adrien2p commented Feb 12, 2024 • edited Loading

changeset-bot bot commented Feb 12, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Feb 12, 2024 • edited Loading

srindom left a comment

Choose a reason for hiding this comment

srindom left a comment

Choose a reason for hiding this comment

olivermrbl Feb 14, 2024

Choose a reason for hiding this comment

adrien2p Feb 14, 2024

Choose a reason for hiding this comment

olivermrbl Feb 14, 2024

Choose a reason for hiding this comment

olivermrbl commented Feb 14, 2024

adrien2p commented Feb 12, 2024 •

edited

Loading

changeset-bot bot commented Feb 12, 2024 •

edited

Loading

vercel bot commented Feb 12, 2024 •

edited

Loading