Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): Fix database test utils and utils #6383

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Feb 12, 2024

What
Fix the test utils database to trully run the migrations, the migration path is deprecated and not used anymore as umzung infer the path under the hood. It also fix the schema so that it is possible to specify different schema if needed.

The index helper can now create named constraints for uniqueness.

extracted from

Copy link

changeset-bot bot commented Feb 12, 2024

🦋 Changeset detected

Latest commit: 425a46f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
medusa-test-utils Patch
@medusajs/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Feb 12, 2024 5:43pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 5:43pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 5:43pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 5:43pm

Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrien2p
Copy link
Member Author

@olivermrbl should we slap an automerge there?

@olivermrbl
Copy link
Contributor

should we slap an automerge there?

Sure thang!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants