Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-flows,dashboard,types,medusa): delete shipping methods when all inbound/outbound items are deleted #9106

Merged
merged 3 commits into from
Sep 11, 2024
Merged

feat(core-flows,dashboard,types,medusa): delete shipping methods when all inbound/outbound items are deleted #9106

merged 3 commits into from
Sep 11, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Sep 11, 2024

what:

  • delete shipping methods when all inbound/outbound items are deleted
    • claims / exchanges / returns
  • updates frontend to update the forms when ^ happens
  • resolved a couple of bugs + types along the way

RESOLVES CC-439

@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 3:24pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 11, 2024 3:24pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:24pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:24pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:24pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:24pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:24pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f5f3adf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review September 11, 2024 14:58
@riqwan riqwan requested a review from a team as a code owner September 11, 2024 14:58
fPolic
fPolic approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@riqwan riqwan merged commit 24704f4 into develop Sep 11, 2024
23 checks passed
@riqwan riqwan deleted the feat/rma-shipping branch September 11, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fPolic fPolic fPolic approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riqwan @fPolic