Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration fails when a shutter isn't available #142

Closed
talonchandler opened this issue Aug 6, 2022 · 1 comment · Fixed by #160
Closed

Calibration fails when a shutter isn't available #142

talonchandler opened this issue Aug 6, 2022 · 1 comment · Fixed by #160
Assignees
Milestone

Comments

@talonchandler
Copy link
Collaborator

Yuming from the Elicieri group had trouble calibrating his LCs because of a poor black level estimate. We traced this problem to a his lack of a shutter. We found a manual workaround: turn off the light source during black level estimation, then turn it back on for the rest of the calibration.

I think a more complete solution will include:

  • a warning to the user if a shutter isn't available
  • a GUI element that lets the user input a black level by hand. This should be a pretty stable value, so I expect this to be a good solution.
@talonchandler talonchandler self-assigned this Aug 10, 2022
@talonchandler talonchandler added this to the 0.2.0 milestone Aug 10, 2022
@ieivanov
Copy link
Contributor

I like this, I can implement it together with #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants