-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update shutter behavior and LF acquisition channel order #160
Conversation
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
==========================================
+ Coverage 11.20% 11.30% +0.09%
==========================================
Files 45 45
Lines 5990 5938 -52
==========================================
Hits 671 671
+ Misses 5319 5267 -52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Preview page for your plugin is ready here: |
This is excellent, Ivan, thanks so much. I'll definitely be able to take this over the finish line. I really like your "warning + default to State0" solution for #110---good call. This fix moved to #162. In the interests of onboarding Ziwen, I'm thinking of testing and completing the fixes for |
I've moved the exposure check to a different PR #162 since the implementation needs work, and this PR will benefit from narrowed scope. |
This reverts commit 55caabe.
No references to this code All functionality was moved to `calibration_workers.py` and/or `main_widget.py`
* Exposure check moved from #160 * seperate exposure check and acquisition methods * simplify code checking and setting exposure times * show the exposure time warning in napari * Tighten warning message. * stop forcing equal exposures and throw an error * update docstring * Minor update to error message. Co-authored-by: Ziwen Liu <67518483+ziw-liu@users.noreply.github.com>
…a-lab/recOrder into bugfix-shutter-channelOrder
This PR is on the larger side. It includes: Features
Non-features
@ziw-liu much of this depends on hardware, but I'd still appreciate a quick second set of eyes on the code before merging. Thanks! |
Quick note: I see that you've removed |
This PR fixes #111. It also starts to address
#110and #142To fully fix #142 we also need to:
@talonchandler could you please help me with those?
Towards addressing #110 I've added a check to ensure that all LF channel exposures are the same. If they are not, all exposures are set to the exposure for State0. That's not a complete solution, but will prevent acquiring corrupted data.