Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meilisearch Cloud: Include documentation for custom user bindings #2680

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Meilisearch Cloud: Include documentation for custom user bindings #2680

merged 1 commit into from
Jan 17, 2024

Conversation

fabio-nettis
Copy link
Contributor

Pull Request

Related issue

Fixes meilisearch/meilisearch#4309

What does this PR do?

This PR includes documentation for the X-MS-USER-ID header. This header allows to manually set the user id associated with a search and subsequent requests to the /event endpoint. Based on the feedback of this issue.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabio-nettis Thanks for the PR, and great job in creating a new <Capsule>.

A couple of comments on my side:

  • hard line breaks often create issues when rendering markdown into HTML, so we prefer to avoid them in regular text
  • I suggested a slightly more informative title for the capsule
  • I also made a few suggestions to make the new capsule text a bit more idiomatic

learn/cloud/analytics.mdx Show resolved Hide resolved
learn/cloud/analytics.mdx Show resolved Hide resolved
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@guimachiavelli guimachiavelli merged commit 5f36b1c into meilisearch:main Jan 17, 2024
1 of 2 checks passed
guimachiavelli added a commit that referenced this pull request Jan 17, 2024
guimachiavelli added a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meilisearch Cloud: Optimize analytics event association handling
2 participants