Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix faulty #2680 merge #2689

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix faulty #2680 merge #2689

merged 1 commit into from
Jan 23, 2024

Conversation

guimachiavelli
Copy link
Member

For some reason #2680 did not reflect my suggestions, despite the user seeming to have accepted them. This PR fixes that by pushing the final text.

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:hotfix-faulty-2680-merge

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@curquiza
Copy link
Member

@guimachiavelli
You can see on the PR no commit has been pushed following your suggestions -> it means the suggestions were not applied

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tutto bene

@guimachiavelli
Copy link
Member Author

huh, you're right. I guess I just assumed the contributor had accepted my suggestions because they had marked my suggestions as resolved without any comment?

@guimachiavelli guimachiavelli merged commit 4ffbba0 into main Jan 23, 2024
2 checks passed
@guimachiavelli guimachiavelli deleted the hotfix-faulty-2680-merge branch January 23, 2024 11:21
@curquiza
Copy link
Member

curquiza commented Jan 23, 2024

huh, you're right. I guess I just assumed the contributor had accepted my suggestions because they had marked my suggestions as resolved without any comment?

Most of the contributors don't know how to use commit suggestions. I think they thought the suggestions would be applied if they click on "Resolve conversation"
When you do suggestions like this, don't wait for their approval -> you are the maintainer, you can apply them directly and then, merge the PR. You will save time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants