Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Add a way to use package version programmatically #233

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Feature/Add a way to use package version programmatically #233

merged 3 commits into from
Feb 8, 2022

Conversation

brunoocasali
Copy link
Member

@brunoocasali brunoocasali commented Feb 3, 2022 •
edited
Loading

  • Create the Version class
  • Load the current version from the csproj data through the GetType>Assembly>GetName>Version (I don’t really know if this could have some potential of not working in some cases, let me know that).

The Github Action for some reason stopped working, I fixed the version of the .net in order to fix the problem.

Related to meilisearch/integration-guides#150

@brunoocasali brunoocasali added the enhancement New feature or request label Feb 3, 2022
@brunoocasali
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Feb 3, 2022
@bors
Try #233:
447defc
@bors
Copy link
Contributor

bors bot commented Feb 3, 2022

try

Build failed:

bidoubiwa
bidoubiwa reviewed Feb 7, 2022
View reviewed changes
src/Meilisearch/Version.cs Outdated Show resolved Hide resolved
src/Meilisearch/Version.cs Show resolved Hide resolved
@brunoocasali brunoocasali mentioned this pull request Feb 7, 2022
Closed
@brunoocasali brunoocasali mentioned this pull request Feb 8, 2022
Closed
20 tasks
@brunoocasali brunoocasali changed the title Create a Version class which contains a way to access the package version programmatically Feature/Analytics Feb 8, 2022
bidoubiwa
bidoubiwa approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥🔥🔥

@brunoocasali
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 8, 2022

Build succeeded:

@bors bors bot merged commit b06bf3d into main Feb 8, 2022
@bors bors bot deleted the add-version branch February 8, 2022 13:27
@brunoocasali brunoocasali changed the title Feature/Analytics Feature/Add a way to use package version programmatically Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

@alallema alallema Awaiting requested review from alallema

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunoocasali @bidoubiwa