Fix dotnet format argument #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet format replace --check with --verify-no-changes
brunoocasali
reviewed
Feb 7, 2022
| @@ -41,4 +41,4 @@ jobs: | |||
| - name: Install dotnet-format | |||
| run: dotnet tool install -g dotnet-format | |||
| - name: Check with dotnet-format | |||
| run: dotnet format --check Meilisearch.sln | |||
| run: dotnet format --verify-no-changes Meilisearch.sln | |||
There was a problem hiding this comment.
Do you know why this change now?
There was a problem hiding this comment.
I had the same problem here: #233 and I "solved" by fixing the version of the action actions/setup-dotnet@v1.
There was a problem hiding this comment.
dotnet format has been integrated with .net 6 sdk. They replaced check by verify-nochanges in order to have names that better fit with dotnet cli.
There was a problem hiding this comment.
Actually, you should keep your change and close this one. Building and testing are done against 3.1.
There was a problem hiding this comment.
Ok, good to know, thanks for sharing the knowledge!
|
Closed, since we will close the issue after the #233 get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dotnet format replace
--checkwith--verify-no-changes