This repository has been archived by the owner on May 9, 2023. It is now read-only.
Changes related to the next Meilisearch release (v0.28.0) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
requested review from
brunoocasali
and removed request for
brunoocasali
brunoocasali
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
I put it as ready to review since you requested my review @alallema :)
I'll approve it, but can we know in advance if this is going to work?
| @@ -17,7 +17,7 @@ | |||
| IMAGE_FORMAT = 'vmdk' | |||
| IMAGE_DESTINATION_URI = f'gs://meilisearch-image/meilisearch-{MEILI_CLOUD_SCRIPTS_VERSION_TAG}-{DEBIAN_BASE_IMAGE_FAMILY}.{IMAGE_FORMAT}' | |||
| IMAGE_DESTINATION_BUCKET_NAME = 'meilisearch-image' | |||
| SERVICE_ACCOUNT_EMAIL = '591812945139-compute@developer.gserviceaccount.com' | |||
There was a problem hiding this comment.
So indeed we had to change something in the permissions 👀
There was a problem hiding this comment.
No, in fact, it was the typo that caused the error. We changed the service account because eskombro prefers to use this one. And yes, it works well, I ran it locally
|
bors merge |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gathers the changes related to the next Meilisearch release (v0.28.0) so that this package is ready when the official release is out.
This PR is auto-generated for the pre-release week purpose.
Related to this issue: meilisearch/integration-guides#205