Skip to content
This repository has been archived by the owner on May 9, 2023. It is now read-only.

Changes related to the next Meilisearch release (v0.28.0) #87

Merged
merged 6 commits into from
Jul 19, 2022
Merged

Changes related to the next Meilisearch release (v0.28.0) #87

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8cf62c9
Update tools/config.py
meili-bot Jun 9, 2022
aced041
Merge branch 'main' into bump-meilisearch-v0.28.0
alallema Jul 11, 2022
feafe72
Revert dependencies
alallema Jul 12, 2022
dd1be94
Changes related to the next Meilisearch release (v0.28.0)
alallema Jul 18, 2022
6b21a12
Fix script publish
alallema Jul 19, 2022
c87f1c5
Merge branch 'main' into bump-meilisearch-v0.28.0
alallema Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ cffi==1.15.0
chardet==5.0.0
google-api-core==2.8.2
google-api-python-client==2.51.0
google-auth==2.9.0
google-auth==2.8.0
google-auth-httplib2==0.1.0
google-cloud-core==2.3.1
google-cloud-storage==2.4.0
Expand Down
12 changes: 6 additions & 6 deletions tools/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@

# Update with the Meilisearch version TAG you want to build the image with

MEILI_CLOUD_SCRIPTS_VERSION_TAG = 'v0.27.1'
MEILI_CLOUD_SCRIPTS_VERSION_TAG = 'v0.28.0'

# Update with the custom image name that you want to publish after TESTING

PUBLISH_IMAGE_NAME = 'meilisearch-v0-27-1-debian-10-build--18-05-2022-14-47-56'
PUBLISH_IMAGE_NAME = 'meilisearch-v0-28-0-debian-10-build--18-07-2022-14-48-17'

# Setup environment and settings

Expand All @@ -17,7 +17,7 @@
IMAGE_FORMAT = 'vmdk'
IMAGE_DESTINATION_URI = f'gs://meilisearch-image/meilisearch-{MEILI_CLOUD_SCRIPTS_VERSION_TAG}-{DEBIAN_BASE_IMAGE_FAMILY}.{IMAGE_FORMAT}'
IMAGE_DESTINATION_BUCKET_NAME = 'meilisearch-image'
SERVICE_ACCOUNT_EMAIL = '591812945139-compute@developer.gserviceaccount.com'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So indeed we had to change something in the permissions 👀

Copy link
Contributor

@alallema alallema Jul 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, in fact, it was the typo that caused the error. We changed the service account because eskombro prefers to use this one. And yes, it works well, I ran it locally

SERVICE_ACCOUNT_EMAIL = '591812945139@cloudbuild.gserviceaccount.com'

USER_DATA = requests.get(
f'https://raw.githubusercontent.com/meilisearch/cloud-scripts/{MEILI_CLOUD_SCRIPTS_VERSION_TAG}/scripts/providers/gcp/cloud-config.yaml'
Expand Down Expand Up @@ -139,10 +139,10 @@
{
'args': [
'-timeout=7000s',
f'-source_image={PUBLISH_IMAGE_NAME}'
f'-source_image={PUBLISH_IMAGE_NAME}',
'-client_id=api',
f'-format={IMAGE_FORMAT}'
f'-destination_uri={IMAGE_DESTINATION_URI}'
f'-format={IMAGE_FORMAT}',
f'-destination_uri={IMAGE_DESTINATION_URI}',
f'-compute_service_account={SERVICE_ACCOUNT_EMAIL}'
],
'name':'gcr.io/compute-image-tools/gce_vm_image_export:release',
Expand Down