Adding generateTenantToken method to the client #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
force-pushed
the
generate_token
branch
from
720ae7e to
81bee3f
Compare
alallema
force-pushed
the
generate_token
branch
from
81bee3f to
1c4ccbc
Compare
alallema
force-pushed
the
generate_token
branch
6 times, most recently
from
55c0e20 to
de9ef9e
Compare
brunoocasali
reviewed
Mar 2, 2022
| * | ||
| * The $options parameter is an array, and the following keys are accepted: | ||
| * - apiKey: The API key parent of the token. If you leave it empty the client API Key will be used. | ||
| * - expiresAt: A DateTime when the key will expire. Note that if an expiresAt value is included it should be in UTC time. |
There was a problem hiding this comment.
What about add some validation about this UTC requirement?
There was a problem hiding this comment.
This helps somehow? https://www.php.net/manual/en/datetime.gettimezone.php
There was a problem hiding this comment.
Are we sure we want to force the user to use the UTC? Rather than putting a note of information?
brunoocasali
reviewed
Mar 3, 2022
tests/Endpoints/TenantTokenTest.php
Outdated
| $this->assertArrayHasKey('hits', $response->toArray()); | ||
| $this->assertArrayHasKey('query', $response->toArray()); | ||
| $this->expectException(ApiException::class); | ||
| $response = $tokenClient->index('tenantTokenDuplicate')->search(''); |
There was a problem hiding this comment.
I think I didn't follow why this test is testing 😬
There was a problem hiding this comment.
It's not mandatory at all I just test if my token had access to the right index depending on the token's searchRules.
bidoubiwa
suggested changes
Mar 7, 2022
src/Endpoints/TenantToken.php
Outdated
Comment on lines
32
to
33
| if (null == $searchRules) { | ||
| throw InvalidArgumentException::emptyArgument('search rules'); |
There was a problem hiding this comment.
I change it for:
if ((!is_array($searchRules) && !is_object($searchRules)) || null == $searchRules) {
throw InvalidArgumentException::emptyArgument('search rules');
}For checking and the type and the fact that searchRules exist
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Mar 7, 2022
297: Adding generateTenantToken method to the client r=alallema a=alallema ## Tenant tokens Introduction of the new method `generateTenantToken` in order to facilitate the generation of the tenant token. Related to: - this issue: meilisearch/meilisearch#1991 - this spec: meilisearch/specifications#89 Co-authored-by: alallema <amelie@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
|
Build failed: |
bors bot
added a commit
that referenced
this pull request
Mar 14, 2022
292: Changes related to the next Meilisearch release (v0.26.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#181 This PR: - gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v0.26.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Done: - #296 - #298 - #297 - #302 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tenant tokens
Introduction of the new method
generateTenantTokenin order to facilitate the generation of the tenant token.Related to: