Changes the Keys Class #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
force-pushed
the
changes-keys
branch
from
7a1beab to
fc1f7f8
Compare
alallema
force-pushed
the
changes-keys
branch
from
fc1f7f8 to
67ba0b9
Compare
alallema
force-pushed
the
changes-keys
branch
from
6fe2891 to
9bc8b58
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Mar 2, 2022
298: Changes the Keys Class r=alallema a=alallema ### Breaking Changes The `class` `Keys` wasn't used as a proper class and did not return objects from the `Keys` but arrays. This has been changed. Setters and Getters have been added to the class. - `client.getKey` return a Keys - `client.createKey` return a Keys - `client.updateKey` return a Keys Co-authored-by: alallema <amelie@meilisearch.com>
|
Build failed: |
|
@alallema is there any particular reason to merge this into the |
bors bot
added a commit
that referenced
this pull request
Mar 14, 2022
292: Changes related to the next Meilisearch release (v0.26.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#181 This PR: - gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v0.26.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Done: - #296 - #298 - #297 - #302 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
The
classKeyswasn't used as a proper class and did not return objects from theKeysbut arrays. This has been changed. Setters and Getters have been added to the class.client.getKeyreturn a Keysclient.createKeyreturn a Keysclient.updateKeyreturn a Keys