Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proximityPrecision management methods #606

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Add proximityPrecision management methods #606

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e48bfd
Add proximityPrecision settings management methods
brunoocasali Jan 10, 2024
3b940dd
Update code-samples
brunoocasali Jan 10, 2024
216bafe
Improve typing system
brunoocasali Jan 10, 2024
7f53abe
Fix phpstan errors
brunoocasali Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/Endpoints/Delegates/HandlesSettings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,18 +352,12 @@ public function getProximityPrecision(): string
return $this->http->get(self::PATH.'/'.$this->uid.'/settings/proximity-precision');
}

/**
* @param non-empty-string $type
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removed this one?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I wonder is it an enum or can be anything?

public function updateProximityPrecision(string $type): string
public function updateProximityPrecision(string $type): array
{
return $this->http->put(self::PATH.'/'.$this->uid.'/settings/proximity-precision', $type);
}

/**
* @return non-empty-string
*/
public function resetProximityPrecision(): string
public function resetProximityPrecision(): array
{
return $this->http->delete(self::PATH.'/'.$this->uid.'/settings/proximity-precision');
}
Expand Down
Loading