Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper typehint for proximityPrecision #610

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Use proper typehint for proximityPrecision #610

merged 1 commit into from
Jan 17, 2024

Conversation

norkunas
Copy link
Collaborator

Pull Request

Related issue

Fixes #606 (comment)

What does this PR do?

  • Declares proper typehint to know what values may be returned/accepted.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas requested a review from brunoocasali January 16, 2024 04:37
@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jan 17, 2024
curquiza
curquiza approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 17, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 4810abd into meilisearch:main Jan 17, 2024
9 checks passed
@norkunas norkunas deleted the proximity-hints branch January 17, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

@brunoocasali brunoocasali Awaiting requested review from brunoocasali

Assignees
No one assigned
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norkunas @curquiza