Add methods to configure new prefixSearch and facetSearch index settings
#702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Hey @norkunas 👋 I went ahead I tagged you as a reviewer since you helped me with the previous PRs. I hope you can assist me with reviewing this one too. 🙏 |
norkunas
approved these changes
Dec 5, 2024
| // Settings - Facet Search | ||
|
|
||
| /** | ||
| * @since Meilisearch v1.12.0 |
There was a problem hiding this comment.
do we really need this annotation (everywhere)?
There was a problem hiding this comment.
I wouldn't say we need it to the point where we should update all the code base. But if it shows up in the generated documentation, then it's useful information for the reader. What do you think?
4 tasks
Strift
changed the title
prefixSearch and facetSearch index settingsprefixSearch and facetSearch index settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #694
What does this PR do?
getSettings(), andupdateSettingsallow the new settingsgetFacetSearch(),updateFacetSearch(), andresetFacetSearch()methodsgetPrefixSearch(),updatePrefixSearch(), andresetPrefixSearch()methods