-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes related to the next MeiliSearch release (v0.21.0) #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meili-bot
added
the
skip-changelog
The PR will not appear in the release changelogs
label
Apr 27, 2021
curquiza
removed
the
skip-changelog
The PR will not appear in the release changelogs
label
Apr 27, 2021
Update Readme
Rename attributes_for_faceting into filterable_attributes
Update WaitForPendingUpdate status
Adapts tests according to v0.21.0 breaking changes
Add missing tests according to new features
Update code samples
Update filterable attributes file
Fix code-samples
Fix code sample
bidoubiwa
suggested changes
Aug 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 154 of index.py
List of all enqueued and processed actions of the index.
missing processing in the list
meilisearch/tests/settings/test_settings_filterable_attributes_meilisearch.py
Outdated
Show resolved
Hide resolved
meilisearch/tests/settings/test_settings_filterable_attributes_meilisearch.py
Outdated
Show resolved
Hide resolved
meilisearch/tests/settings/test_settings_filterable_attributes_meilisearch.py
Outdated
Show resolved
Hide resolved
meilisearch/tests/settings/test_settings_filterable_attributes_meilisearch.py
Outdated
Show resolved
Hide resolved
…_meilisearch.py Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
…_meilisearch.py Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
…_meilisearch.py Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
…_meilisearch.py Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Fix forgotten attribute for faceting after review
bidoubiwa
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue: meilisearch/integration-guides#117
This PR:
This PR is auto-generated for the pre-release week purpose. Exceptionally for this release, the pre-release time will be more than just one week.
Done:
attributes_for_faceting
intofilterable_attributes
Rename attributes_for_faceting into filterable_attributes #287 Update filterable attributes file #292WaitForPendingUpdate
status Update WaitForPendingUpdate status #288buildDate
intocommitDate
rankingRules
exhaustiveFacetsCount
returnFalse