-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes related to MeiliSearch v0.21.0 #117
Comments
There are additionnal breaking changes that are due to either fixes or undefined behavior becoming defined:
|
Some error codes have been added or removed and impact SDK's listing all error codes:
Impacted SDK's: |
The complete list of code-samples that must be updated are here. Code samplesUpdate
|
@bidoubiwa the JS SDK will be impacted by this breaking change you found out 😇 |
Absolutely! The tests were commented out until a decision was taken. I will update them asap |
115: Changes related to the next MeiliSearch release (v0.21.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#117 This PR: - gathers the changes related to the next MeiliSearch release (v0.21.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). Until there is an RC version, the tests should be valid against the [alpha versions of transplant](https://github.com/meilisearch/transplant/releases). - might eventually contain test failures until the MeiliSearch v0.21.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.21.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose. Exceptionally for this release, the pre-release time will be more than just one week._ Done: - Update README #135 - Rename buildDate into commitDate #134 - Update `wait_for_pending_update` #136 - Rename attributes_for_faceting into filterable_attributes #137 - Filtering use Filter #138 - Rename `FieldsDsitribution` into `FieldDistribution` #139 - Adding new field in dump #140 - Fix part of the tests and add missing tests #141 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com>
161: Changes related to the next MeiliSearch release (v0.21.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#117 This PR: - gathers the changes related to the next MeiliSearch release (v0.21.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). Until there is an RC version, the tests should be valid against the [alpha versions of transplant](https://github.com/meilisearch/transplant/releases). - might eventually contain test failures until the MeiliSearch v0.21.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.21.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose. Exceptionally for this release, the pre-release time will be more than just one week._ Done: - Update README and code sample #188 #195 #196 - Update `waitForPendingUpdate` status #189 - Rename `attributesForFaceting` into `filterableAttributes` #190 - Adapts tests according to v0.21.0 breaking changes #191 - Rename `buildDate` into `commitDate` - Rename `fieldsDistribution` into `fieldDiestribution` - Update `rankingRules` - Fix tests and Add missing tests according to new features #192 #194 - Add phrase search tests - Add search test including filter with number - Test with filter as an array Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com>
144: Changes related to the next MeiliSearch release (v0.21.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#117 This PR: - gathers the changes related to the next MeiliSearch release (v0.21.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). Until there is an RC version, the tests should be valid against the [alpha versions of transplant](https://github.com/meilisearch/transplant/releases). - might eventually contain test failures until the MeiliSearch v0.21.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.21.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose. Exceptionally for this release, the pre-release time will be more than just one week._ Done: - Update README and code sample #165 - Update `WaitForPendingUpdate` status #166 - Rename `attributes_for_faceting` into `filterable_attributes` #167 - Rename `Filters` into `Filter` #168 #181 - Rename `FieldDistribution` #169 - Adding `FinishedAt` in Dump #170 - Rename fields `buildDate` into `commitDate` #171 - Fix tests and Add missing tests according to new features #172 - Update code sample file #176 #182 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: alallema <amelie@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
130: Changes related to the next MeiliSearch release (v0.21.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#117 This PR: - gathers the changes related to the next MeiliSearch release (v0.21.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). Until there is an RC version, the tests should be valid against the [alpha versions of transplant](https://github.com/meilisearch/transplant/releases). - might eventually contain test failures until the MeiliSearch v0.21.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.21.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose. Exceptionally for this release, the pre-release time will be more than just one week._ Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: orange soeur <juzi201314@gmail.com>
250: Changes related to the next MeiliSearch release (v0.21.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#117 This PR: - gathers the changes related to the next MeiliSearch release (v0.21.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). Until there is an RC version, the tests should be valid against the [alpha versions of transplant](https://github.com/meilisearch/transplant/releases). - might eventually contain test failures until the MeiliSearch v0.21.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.21.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose. Exceptionally for this release, the pre-release time will be more than just one week._ Done: - Update README #286 - Rename `attributes_for_faceting` into `filterable_attributes` #287 #292 - Update `WaitForPendingUpdate` status #288 - Adapts tests according to v0.21.0 breaking changes #289 - Rename fields `buildDate` into `commitDate` - Update `rankingRules` - `exhaustiveFacetsCount` return `False` - Add missing tests according to new features #290 - Phrase search tests - Filter/facet on number is now doable - Test the syntax on Filter array and string - Update code sample file #291 #293 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com>
875: Changes related to the next MeiliSearch release (v0.21.0) r=bidoubiwa a=meili-bot Related to this issue: meilisearch/integration-guides#117 This PR: - gathers the changes related to the next MeiliSearch release (v0.21.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). Until there is an RC version, the tests should be valid against the [alpha versions of transplant](https://github.com/meilisearch/transplant/releases). - might eventually contain test failures until the MeiliSearch v0.21.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.21.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose. Exceptionally for this release, the pre-release time will be more than just one week._ Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
157: Changes related to the next MeiliSearch release (v0.21.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#117 This PR: - gathers the changes related to the next MeiliSearch release (v0.21.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). Until there is an RC version, the tests should be valid against the [alpha versions of transplant](https://github.com/meilisearch/transplant/releases). - might eventually contain test failures until the MeiliSearch v0.21.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.21.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose. Exceptionally for this release, the pre-release time will be more than just one week._ Done: - Update README #176 - Rename `buildDate` into `commitDate` #177 - Rename `attributes_for_faceting` into `filterable_attributes` #178 - Rename `FieldsDsitribution` into `FieldDistribution` #179 - Add Fields in Dump #180 - Rename Filters into Filter #181 - Fix part of the tests #182 - Add missing tests according to new features #186 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
169: Changes related to the next MeiliSearch release (v0.21.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#117 This PR: - gathers the changes related to the next MeiliSearch release (v0.21.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). Until there is an RC version, the tests should be valid against the [alpha versions of transplant](https://github.com/meilisearch/transplant/releases). - might eventually contain test failures until the MeiliSearch v0.21.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.21.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose. Exceptionally for this release, the pre-release time will be more than just one week._ ---- Done: - Update README - Update `wait_for_pending_update` #191 - Rename `attributes_for_faceting` into `filterable_attributes` #192 -> BREAKING - Filtering #193 - Rename FieldsDsitribution into FieldDistribution #194 - Fix part of the tests #195 - Add missing tests according to new features #196 - Fix facetsDistribution tests #197 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
40: Changes related to the next MeiliSearch release (v0.21.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#117 This PR: - gathers the changes related to the next MeiliSearch release (v0.21.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). Until there is an RC version, the tests should be valid against the [alpha versions of transplant](https://github.com/meilisearch/transplant/releases). - might eventually contain test failures until the MeiliSearch v0.21.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.21.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose. Exceptionally for this release, the pre-release time will be more than just one week._ Done: - Update README #60 - Rename `attributes_for_faceting` into `filterable_attributes` #61 - Add `processing` status to check in `PendingUpdateX()` method #62 - Filtering use Filter #63 - Add tests according to new features #64 #65 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: alallema <amelie@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
117: Changes related to the next MeiliSearch release (v0.21.0) r=bidoubiwa a=meili-bot Related to this issue: meilisearch/integration-guides#117 This PR: - gathers the changes related to the next MeiliSearch release (v0.21.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). Until there is an RC version, the tests should be valid against the [alpha versions of transplant](https://github.com/meilisearch/transplant/releases). - might eventually contain test failures until the MeiliSearch v0.21.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.21.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose. Exceptionally for this release, the pre-release time will be more than just one week._ Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Done! Well done everyone! 😄 |
This issue gathers the changes related to the v0.21.0 of MeiliSearch that will impact the integrations
Ranaming of
buildDate
intocommitDate
Related to meilisearch/transplant#138.
Will impact all the SDKs implementing the method for
/version
route.New update status value
Related to meilisearch/transplant#107.
The new status for an update are:
enqueued
: the update is enqueued and will start to be processed soonprocessing
: the update is processing.processed
: the update is processed and it succeeded.failed
: A failure occurred during when processing.Will impact all the SDKs:
waitForPendingUpdate
methodThe
waitForPendingUpdate
must now check if the status of the update is different fromenqueued
orprocessing
, not onlyenqueued
.New ranking rules
Related to meilisearch/transplant#85
Will impact some tests in some SDKs
Will also impact docs-scraper
Phrase search
Related to meilisearch/transplant#198
The SDK should test the phrase search, I mean the SDK can handle
"
in theq
parameter, like:"
can be handled.Filterable attributes
Related to meilisearch/transplant#187
attributesForFaceting
is renamed intofilterableAttributes
.code-samples.yml
will change! Don't forget to update the keys!Filtering
Related to meilisearch/transplant#81 and meilisearch/transplant#140
filters
is renamed intofilter
facetFilters
is removedfilter
can accept both syntaxes: array of string and string -> the tests should check both syntaxes are handledfilterableAttributes
-> it might impact the instant-meilisearch README?New fields in dumps routes
Related to meilisearch/transplant#20
GET /dumps/:uid/status
route:startedAt
andfinishedAt
ex:
curl -X GET 'http://localhost:7700/dumps/20210601-144339391/status'
POST /dumps
route:startedAt
ex:
curl -X POST 'http://localhost:7700/dumps'
Impacts SDKs and tests.
Rename
fieldsDistribution
intofieldDistribution
Related to: meilisearch/transplant#188
Rename
fieldsDistribution
intofieldDistribution
.Impacts SDKs and tests.
Stop-words and synonyms accept
null
Related to meilisearch/transplant#217
The user can pass the
null
value when updating the settings (usingPOST
). This resets the setting to its default value.In MeilISearch v0.20 this behavior is possible for all the settings except the synonyms and the stop-words. The v0.21.0 should make all the settings consistent by allowing the
null
value when updating.Impacts SDK tests -> we should add tests to check we can pass a
null
value when updating the synonyms and the stop-words. The tests for the other settings (when passing anull
value`) are already done thanks to @alallema!0
value are not present infacetsDistribution
Related to meilisearch/transplant#234
This might impact SDK tests.
exhaustiveFacetsCount
always returnsfalse
Related to meilisearch/transplant#236
This might impact SDK tests
TODO
SDKs:
Front-end:
Back-end:
Misc:
🔥🔥🔥 Don't forget the code-samples and the READMEs 🔥🔥🔥
The text was updated successfully, but these errors were encountered: