Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

filters and facetsFilters #81

Closed
1 task done
curquiza opened this issue Mar 10, 2021 · 4 comments · Fixed by #179
Closed
1 task done

filters and facetsFilters #81

curquiza opened this issue Mar 10, 2021 · 4 comments · Fixed by #179
Labels
breaking Spec related Related to a spec (https://github.com/meilisearch/specifications/)

Comments

@curquiza
Copy link
Member

curquiza commented Mar 10, 2021 •
edited
Loading

A big change with the new search engine is impossible to filter during a search if the fields are not set asattributesForFaceting.

So, now, facetFilters and filters during the search does the same job. Should we keep them both?
We have to investigate why algolia has many ways to filter to know what to do.

Currently, in transplant, the filters attributes does nothing, use facetFilters instead.

Final decision:

Final decision related to this spec:

  • The facetFilters parameter should not be present anymore, only filter (without the s) is usable.
@curquiza
Copy link
Member Author

Rectification: filters does not work in the current alpha, use facetFilters instead to do your tests!

@curquiza curquiza changed the title filters needs to be faceted to be used filters and facetsFilters Mar 23, 2021
@curquiza
Copy link
Member Author

curquiza commented Mar 23, 2021 •
edited
Loading

Another thing to decide: which syntax should we keep?

  • the array syntax?
  • the AND/OR syntax?
  • Or both??

This will be fixed in #140

@curquiza
Copy link
Member Author

curquiza commented Apr 8, 2021

I've updated the issue description with the final decision

@curquiza curquiza removed the need-spec label Apr 8, 2021
@curquiza curquiza added the Spec related Related to a spec (https://github.com/meilisearch/specifications/) label Apr 14, 2021
@curquiza
Copy link
Member Author

⚠️ I updated the issue, the parameter filters is now filter.

@MarinPostma MarinPostma mentioned this issue May 4, 2021
Merged
@dichotommy dichotommy mentioned this issue May 24, 2021
Merged
73 tasks
bors bot added a commit that referenced this issue Jun 3, 2021
@bors @MarinPostma
Merge #179
9a38981 
179: enable filter r=irevoire a=MarinPostma

This pr makes the necessary changes to transplant in accordance with the specification on filters.

More precisely, it:
- Removes the `filters` parameter
- Renames `facetFilters` to `filter`
- Allows either a string or an array to be passed to the filter param.

It doesn't allow the mixed syntax, that needs to be handled by milli.

close #81
close #140


Co-authored-by: Marin Postma <postma.marin@protonmail.com>
@bors bors bot closed this as completed in d765397 Jun 14, 2021
@curquiza curquiza mentioned this issue Jun 22, 2021
Closed
14 tasks
This was referenced Jul 5, 2021
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking Spec related Related to a spec (https://github.com/meilisearch/specifications/)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable filter parameter during search meilisearch/transplant
1 participant
@curquiza