This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Rename attributesForFaceting into filterableAttributes #187
Labels
breaking
good first issue
Good for newcomers
Spec related
Related to a spec (https://github.com/meilisearch/specifications/)
Comments
curquiza
added
good first issue
bors bot
added a commit
to meilisearch/milli
that referenced
this issue
Jun 2, 2021
204: Decorrelate Distinct, Asc/Desc, Filterable fields from the faceted fields r=Kerollmops a=Kerollmops This PR decorrelates the fields that need to be stored in facet databases (big inverted indexes for fast access) from the filterable fields, the previously named faceted fields are now named filterable fields and are the union of the distinct attribute, all the Asc/Desc criteria and, the filterable fields. I added two tests to make sure that the engine was correctly generating the faceted databases when a distinct attribute or an Asc/Desc criteria were added, and one to make sure that it was impossible to filter on a non-filterable field even if it was a faceted one. Note that the `AttributesForFacetting` has also been renamed into `FilterableAttributes`. But it will be the Transplant's job to do that on the API, this change is only visible to the milli's library users. - Related to meilisearch/transplant#187. - Fixes #161 by returning the documents that don't have the Asc/Desc field at the end of the bucket. - Fixes #168. - Fixes #152. Co-authored-by: Kerollmops <clement@meilisearch.com> Co-authored-by: Marin Postma <postma.marin@protonmail.com> Co-authored-by: many <maxime@meilisearch.com>
14 tasks
This was referenced Jul 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Related to the following spec:https://github.com/meilisearch/specifications/blob/main/text/0032-distinct-attribute.md
The text was updated successfully, but these errors were encountered: