This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indexes API #132
Indexes API #132
Changes from all commits
21bf3ad
a7d6f3f
55a2f5e
c0428ae
cf7f2a6
2c31bee
c39b407
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modify
? What do you meanI thought it was:
When the index has been set, it can never be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a free change that was made by the core team a while ago. It has not been specially communicated at that time. If the index is empty, you can update the
primaryKey
😇 Is it useful to be mentioned somewhere? Maybe in the doc?Signal to @meilisearch/docs-team. You may want to mention that behavior somewhere 📡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! I think it is important yes since I'm always answering to users asking how to change their primary key that they
cannot change it whenever they set it or once they added one document
but - I don't know since when - this is wrong haha.So yes, I think the doc should be updated on the matter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eskombro is maybe also not aware this behavior changed. It may (or not in which case sorry) be of interest to him.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation issue created: meilisearch/documentation#1574