Filter operators - `IS NULL` and `IS EMPTY` filter operators #232

Kerollmops · 2023-04-27T13:13:49Z

This PR is updating the search API specification and, specifically the filter field. It explains the support of the IS NULL and IS EMPTY operators. The original PR is available on GitHub, and the original product discussion too!

Changes

Explain the IS EMPTY operator on the filter field of the search API
Explain the IS NULL operator on the filter field of the search API

Attention To Reviewers

Explain clearly what reviewers should specifically look for to facilitate the review phase. Also, mention the sections that will not necessarily be taken into account if reviewed.

Misc

[] Update OpenAPI specification file (if needed; Apply the OpenApi label)
[] Update telemetry datapoints (if needed; Apply the Telemetry label)

gmourier · 2023-04-27T14:20:31Z

Thank you @Kerollmops I see an OpenAPI label, but I don't see any changes on the open-api.yml spec. I don't think it should since we are not describing every possible operator on the open API. We could do that in a future iteration if needed!

I've put the PR in Ready For Review + added the required labels

gmourier · 2023-04-27T14:25:03Z

cc @macraig I added you as a reviewer so you can follow the process and participate in it ✨

ahmednfwela · 2023-04-29T05:03:41Z

One thing to note, is that currently there is no way to use the new IS filter with the IN filter
but you can do
tag IS NULL OR tag IN ["hello", "world"]

gmourier

Thank you @Kerollmops

Some comments about the document structures (section and naming about introduced parts)

text/0118-search-api.md

gmourier · 2023-05-02T10:59:20Z

Hey @ahmednfwela 👋

What do you mean by "One thing to note, is that currently there is no way to use the new IS filter with the IN filter"?

Thanks!

ahmednfwela · 2023-05-02T11:02:50Z

@gmourier you can't use tags IN [IS NULL, "action"] for example which might be a common query that people expect,so I thought it would be cool to document it

gmourier · 2023-05-02T11:06:20Z

Thank you for the precision, @ahmednfwela !

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

irevoire

Looks perfect to me, especially with the list of empty value 👌

gmourier

Thank you @Kerollmops ! 🚂

* Bump OpenAPI version * CSV Content-Type — Add support for the boolean type in CSV (#228) * add support for the boolean type in csv * fix a typo * Update text/0028-indexing-csv.md --------- Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Filter operators - `IS NULL` and `IS EMPTY` filter operators (#232) * Introduce the spec of the IS EMPTY filter * Introduce the spec of the IS NULL filter * Fix suggestions * Uppercase the IN operator Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Fix a title number issue Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> --------- Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Search Algorithms Refactor: Relevancy Changes (#233) * Remove old exactness-criterion specification * Remove old asc-desc-criterion specification * Get and delete documents by filter (#236) * specify the new fetch documents route * update open-api * try to be nice with bumpsh * specify the new analytics of the get/fetch documents route * group the analytics behind already used groups * fix a placeholder text * group the get and fetch route under a common section * rename the section to contain the name of both routes * clarify how to send the parameter to both routes * fix the type of the parameters * add the new fetch route to the api keys actions * capitalize json Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> * update open-api * Specify the new route to delete documents by filter * add the new analytics event * improve a comment * add the post - delete route to the api key actions * Fix the json payload Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Update the details Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * delete the invalid_document_delete_filter error code and introduce the missing_document_filter * fix the open-api thingy --------- Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Auto deletion of tasks (#238) * auto deletion of tasks * Update text/0060-tasks-api.md Co-authored-by: gui machiavelli <hey@guimachiavelli.com> * Update text/0060-tasks-api.md Co-authored-by: gui machiavelli <hey@guimachiavelli.com> --------- Co-authored-by: gui machiavelli <hey@guimachiavelli.com> * Experimental reduce indexing memory usage (#239) * Add the experimental-reduce-indexing-memory-usage option in the telemetry policies * Add the experimental-reduce-indexing-memory-usage option in the instance options * Update 0055-sort.md (#240) related to meilisearch/meilisearch#3749 * Update `payload_too_large` error `message` (#241) * Update 0061-error-format-and-definitions.md Update error message in the specification * Update open-api.yaml --------- Co-authored-by: Tamo <tamo@meilisearch.com> Co-authored-by: Clément Renault <renault.cle@gmail.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> Co-authored-by: gui machiavelli <hey@guimachiavelli.com> Co-authored-by: Many the fish <legendre.maxime.isn@gmail.com>

Kerollmops added 2 commits April 27, 2023 15:02

Introduce the spec of the IS EMPTY filter

1bd6588

Introduce the spec of the IS NULL filter

8787bb1

Kerollmops added the OpenAPI Update OpenAPI specification. label Apr 27, 2023

This was referenced Apr 27, 2023

IS NULL filter operator meilisearch/meilisearch#3615

Closed

IS EMPTY filter operator meilisearch/meilisearch#3614

Closed

gmourier marked this pull request as ready for review April 27, 2023 14:20

gmourier added Ready For Review Feature specification must be reviewed. v1.2.0 labels Apr 27, 2023

Kerollmops removed the OpenAPI Update OpenAPI specification. label Apr 27, 2023

gmourier requested review from irevoire, gmourier and macraig April 27, 2023 14:22

gmourier changed the title ~~Is null is empty filters~~ Filter operators - Additions of IS NULL and IS EMPTY operators Apr 27, 2023

gmourier changed the title ~~Filter operators - Additions of IS NULL and IS EMPTY operators~~ Filter operators - IS NULL and IS EMPTY filter operators Apr 27, 2023

gmourier mentioned this pull request Apr 27, 2023

Release v1.2.0 #227

Merged

1 task

gmourier requested a review from curquiza May 2, 2023 07:21

gmourier suggested changes May 2, 2023

View reviewed changes

text/0118-search-api.md Outdated Show resolved Hide resolved

text/0118-search-api.md Outdated Show resolved Hide resolved

text/0118-search-api.md Outdated Show resolved Hide resolved

text/0118-search-api.md Show resolved Hide resolved

Fix suggestions

ea4b757

gmourier suggested changes May 2, 2023

View reviewed changes

text/0118-search-api.md Outdated Show resolved Hide resolved

text/0118-search-api.md Outdated Show resolved Hide resolved

Kerollmops and others added 2 commits May 2, 2023 13:46

Uppercase the IN operator

afab9b3

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

Fix a title number issue

57c42f4

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

Kerollmops requested a review from gmourier May 2, 2023 11:47

irevoire approved these changes May 2, 2023

View reviewed changes

gmourier approved these changes May 2, 2023

View reviewed changes

gmourier added Implemented Feature specification has been implemented. and removed Ready For Review Feature specification must be reviewed. labels May 2, 2023

brunoocasali mentioned this pull request May 10, 2023

Changes regarding Meilisearch v1.2.0 meilisearch/integration-guides#261

Closed

guimachiavelli mentioned this pull request May 10, 2023

v1.2: Add new IS NULL and IS EMPTY filter operators meilisearch/documentation#2415

Closed

1 task

gmourier added the Q2:2023 label May 16, 2023

macraig approved these changes Jun 1, 2023

View reviewed changes

macraig merged commit e74e3a2 into release-v1.2.0 Jun 5, 2023

macraig deleted the is-null-is-empty-filters branch June 5, 2023 15:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Filter operators - `IS NULL` and `IS EMPTY` filter operators #232

Filter operators - `IS NULL` and `IS EMPTY` filter operators #232

Kerollmops commented Apr 27, 2023 •

edited by gmourier

Loading

gmourier commented Apr 27, 2023 •

edited

Loading

gmourier commented Apr 27, 2023 •

edited

Loading

ahmednfwela commented Apr 29, 2023

gmourier left a comment

gmourier commented May 2, 2023

ahmednfwela commented May 2, 2023

gmourier commented May 2, 2023

irevoire left a comment

gmourier left a comment

Filter operators - IS NULL and IS EMPTY filter operators #232

Filter operators - IS NULL and IS EMPTY filter operators #232

Conversation

Kerollmops commented Apr 27, 2023 • edited by gmourier Loading

Changes

Attention To Reviewers

Misc

gmourier commented Apr 27, 2023 • edited Loading

gmourier commented Apr 27, 2023 • edited Loading

ahmednfwela commented Apr 29, 2023

gmourier left a comment

Choose a reason for hiding this comment

gmourier commented May 2, 2023

ahmednfwela commented May 2, 2023

gmourier commented May 2, 2023

irevoire left a comment

Choose a reason for hiding this comment

gmourier left a comment

Choose a reason for hiding this comment

Filter operators - `IS NULL` and `IS EMPTY` filter operators #232

Filter operators - `IS NULL` and `IS EMPTY` filter operators #232

Kerollmops commented Apr 27, 2023 •

edited by gmourier

Loading

gmourier commented Apr 27, 2023 •

edited

Loading

gmourier commented Apr 27, 2023 •

edited

Loading