Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Search Algorithms Refactor: Relevancy Changes #233

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

gmourier
Copy link
Member

@gmourier gmourier commented May 3, 2023

🤖 API Diff Put the link of the GitHub comment generated by bump.sh if generated; Apply the OpenApi label


Summary

  • Introduce information about relevancy changes brought by #3542 that are worth being mentioned
  • Clean old specifications related to relevancy

Changes

Cleaning

  • Remove the old 0036-exactness-criterion.md specification - Ranking rules have already been described in 0123-ranking-rules-setting-api.md.
  • Remove the old 0030-asc-desc-criterion.md specification - Ranking rules have already been described in 0123-ranking-rules-setting-api.md.

Addition/Update

  • ...

Out Of Scope

N/A


Attention To Reviewers

N/A


Misc

  • [] Update OpenAPI specification file (if needed; Apply the OpenApi label)
  • [] Update telemetry datapoints (if needed; Apply the Telemetry label)

@gmourier gmourier added Catch-Up The PR describes already implemented behaviors. v1.2.0 In Progress Feature specification is in elaboration. Important changes can still occurs in the specification. labels May 3, 2023
@ManyTheFish
Copy link
Member

@gmourier, it looks good to me

@dureuill
Copy link
Contributor

dureuill commented May 16, 2023

Looks good to me, thanks @gmourier

@gmourier gmourier added Ready For Review Feature specification must be reviewed. and removed In Progress Feature specification is in elaboration. Important changes can still occurs in the specification. labels May 16, 2023
@gmourier gmourier removed the Ready For Review Feature specification must be reviewed. label May 24, 2023
@macraig macraig merged commit d6d5751 into release-v1.2.0 Jun 5, 2023
@macraig macraig deleted the relevancy-changes branch June 5, 2023 15:43
macraig pushed a commit that referenced this pull request Jun 5, 2023
* Bump OpenAPI version

* CSV Content-Type — Add support for the boolean type in CSV (#228)

* add support for the boolean type in csv

* fix a typo

* Update text/0028-indexing-csv.md

---------

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Filter operators - `IS NULL` and `IS EMPTY` filter operators (#232)

* Introduce the spec of the IS EMPTY filter

* Introduce the spec of the IS NULL filter

* Fix suggestions

* Uppercase the IN operator

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Fix a title number issue

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

---------

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Search Algorithms Refactor: Relevancy Changes (#233)

* Remove old exactness-criterion specification

* Remove old asc-desc-criterion specification

* Get and delete documents by filter (#236)

* specify the new fetch documents route

* update open-api

* try to be nice with bumpsh

* specify the new analytics of the get/fetch documents route

* group the analytics behind already used groups

* fix a placeholder text

* group the get and fetch route under a common section

* rename the section to contain the name of both routes

* clarify how to send the parameter to both routes

* fix the type of the parameters

* add the new fetch route to the api keys actions

* capitalize json

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* update open-api

* Specify the new route to delete documents by filter

* add the new analytics event

* improve a comment

* add the post - delete route to the api key actions

* Fix the json payload

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Update the details

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* delete the invalid_document_delete_filter error code and introduce the missing_document_filter

* fix the open-api thingy

---------

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Auto deletion of tasks (#238)

* auto deletion of tasks

* Update text/0060-tasks-api.md

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>

* Update text/0060-tasks-api.md

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>

---------

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>

* Experimental reduce indexing memory usage (#239)

* Add the experimental-reduce-indexing-memory-usage option in the telemetry policies

* Add the experimental-reduce-indexing-memory-usage option in the instance options

* Update 0055-sort.md (#240)

related to meilisearch/meilisearch#3749

* Update `payload_too_large` error `message` (#241)

* Update 0061-error-format-and-definitions.md

Update error message in the specification

* Update open-api.yaml

---------

Co-authored-by: Tamo <tamo@meilisearch.com>
Co-authored-by: Clément Renault <renault.cle@gmail.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
Co-authored-by: Many the fish <legendre.maxime.isn@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Catch-Up The PR describes already implemented behaviors. Q2:2023 v1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants