This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Document the latest metrics improvements #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
added
Ready For Review
This was referenced May 30, 2023
gmourier
suggested changes
May 31, 2023
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
gmourier
reviewed
May 31, 2023
There was a problem hiding this comment.
@irevoire I just realized we have a sampleResponse field listing some metrics values under the Open API /metrics endpoint; we could either remove that sample response or update the example by including the meilisearch_ prefix. It's up to you!
94noni
reviewed
May 31, 2023
macraig
approved these changes
Jun 1, 2023
gmourier
reviewed
Jun 5, 2023
gmourier
suggested changes
Jun 5, 2023
meili-bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Jun 6, 2023
3789: Improve the metrics r=dureuill a=irevoire # Pull Request ## Related issue Implements #3790 Associated specification: meilisearch/specifications#242 ## Be cautious; it's DB-breaking 😱 While reviewing and after merging this PR, be cautious; if you already have a `data.ms` and run meilisearch with this code on it, it won't work because we need to cache a new information on the index stats (that are backed up on disk). You'll get internal errors. ### About the breaking-change label We only break the API of the metrics route, which does not pose any problem since it's experimental. ## What does this PR do? - Create a method to get the « facet distribution » of the task queue. - Prefix all the metrics by `meilisearch_` - Add the real database size used by meilisearch - Add metrics on the task queue - Update the grafana dashboard to these new changes - Move the dashboard to the `assets` directory - Provide a new prometheus file to scrape meilisearch easily Co-authored-by: Tamo <tamo@meilisearch.com>
gmourier
approved these changes
Jul 31, 2023
macraig
added a commit
that referenced
this pull request
Jul 31, 2023
* Bump openapi.yaml file * Facet Search API (#246) * Init specification * Adjust spec files to PR number * Fix content-type open-api * Remove fix content-type * Add the telemetry * Update text/0246-facet-search-api.md Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> * Update text/0034-telemetry-policies.md --------- Co-authored-by: Clément Renault <clement@meilisearch.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> * Faceting Setting API - sortFacetValuesBy (#247) * init spec * Add property description and open-api.yaml * Removes future possibility * Update the telemetry * Update the error of the sortFacetValuesBy setting --------- Co-authored-by: Clément Renault <clement@meilisearch.com> * Vector Search - `EXPERIMENTAL` (#248) * Init spec * Fix the vector store fields * Add an information on the invalid_search_vector error code * Add an information on the invalid_vectors_field error codes * Define the new max_vector_size analytic * Update the open-api file with vector capabilities * Apply suggestions from code review * Update open-api.yaml Co-authored-by: Maria Craig <marycraig90@gmail.com> * Update open-api.yaml Co-authored-by: Maria Craig <marycraig90@gmail.com> * Update text/0118-search-api.md Co-authored-by: Maria Craig <marycraig90@gmail.com> * Update text/0061-error-format-and-definitions.md Co-authored-by: Maria Craig <marycraig90@gmail.com> --------- Co-authored-by: Kerollmops <clement@meilisearch.com> Co-authored-by: Maria Craig <marycraig90@gmail.com> * Tasks route total (#253) * Update the tasks route info to add the total field * Update the OpenApi of the tasks route * Document the latest metrics improvements (#242) * document the latest metrics improvements * Update text/0174-metrics-api.md Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Update text/0174-metrics-api.md Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * adds some details on the meilisearch_db_size metrics * update the open api metrics smaple * update a bad copy paste * Update open-api.yaml * prefix prometheus metrics by meilisearch_ * Introduce two new metrics --------- Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> Co-authored-by: Kerollmops <clement@meilisearch.com> --------- Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> Co-authored-by: Clément Renault <clement@meilisearch.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> Co-authored-by: Clément Renault <renault.cle@gmail.com> Co-authored-by: Tamo <tamo@meilisearch.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 API Diff Put the link of the GitHub comment generated by bump.sh if generated; Apply the
OpenApilabelSummary
Implemented in meilisearch/meilisearch#3789
meilisearchso they're easier to findmeilisearch_last_updateandmeilisearch_is_indexingintroduced in Metrics: expose two new indexing stats meilisearch#3843