This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Faceting Setting API - sortFacetValuesBy #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmourier
added
the
In Progress
gmourier
changed the title
|
🚨 Breaking API change detected: Modified (5)
|
4 tasks
Kerollmops
force-pushed
the
sort-facet-values-by-setting
branch
from
fa1f9ca
to
d371164
Compare
gmourier
added
Telemetry
macraig
approved these changes
Jul 10, 2023
bidoubiwa
approved these changes
Jul 10, 2023
| @@ -522,6 +526,8 @@ This property allows us to gather essential information to better understand on | |||
| |---------------|-------------|---------| | |||
| | user_agent | Represents the user-agent encountered on this call. | `["Meilisearch Ruby (v2.1)", "Ruby (3.0)"]` | | |||
| | faceting.max_values_per_facet | The defined value for `maxValuesPerFacet` property | `100` | | |||
| | faceting.sort_facet_values_by_star_count | Whether the user set all fields to be sort by count | `true` | | |||
There was a problem hiding this comment.
Why is this called faceting.sort_facet_values_by_star_count instead of just faceting.sort_facet_values_by_count?
There was a problem hiding this comment.
We want to track if the default * is expressly set to count to re-evaluate the default value in the future (today it's alpha). tbh we didn't spent too much time thinking about the name, that's a telemetry point nothing critical here 😇
macraig
added a commit
that referenced
this pull request
Jul 31, 2023
* Bump openapi.yaml file * Facet Search API (#246) * Init specification * Adjust spec files to PR number * Fix content-type open-api * Remove fix content-type * Add the telemetry * Update text/0246-facet-search-api.md Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> * Update text/0034-telemetry-policies.md --------- Co-authored-by: Clément Renault <clement@meilisearch.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> * Faceting Setting API - sortFacetValuesBy (#247) * init spec * Add property description and open-api.yaml * Removes future possibility * Update the telemetry * Update the error of the sortFacetValuesBy setting --------- Co-authored-by: Clément Renault <clement@meilisearch.com> * Vector Search - `EXPERIMENTAL` (#248) * Init spec * Fix the vector store fields * Add an information on the invalid_search_vector error code * Add an information on the invalid_vectors_field error codes * Define the new max_vector_size analytic * Update the open-api file with vector capabilities * Apply suggestions from code review * Update open-api.yaml Co-authored-by: Maria Craig <marycraig90@gmail.com> * Update open-api.yaml Co-authored-by: Maria Craig <marycraig90@gmail.com> * Update text/0118-search-api.md Co-authored-by: Maria Craig <marycraig90@gmail.com> * Update text/0061-error-format-and-definitions.md Co-authored-by: Maria Craig <marycraig90@gmail.com> --------- Co-authored-by: Kerollmops <clement@meilisearch.com> Co-authored-by: Maria Craig <marycraig90@gmail.com> * Tasks route total (#253) * Update the tasks route info to add the total field * Update the OpenApi of the tasks route * Document the latest metrics improvements (#242) * document the latest metrics improvements * Update text/0174-metrics-api.md Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Update text/0174-metrics-api.md Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * adds some details on the meilisearch_db_size metrics * update the open api metrics smaple * update a bad copy paste * Update open-api.yaml * prefix prometheus metrics by meilisearch_ * Introduce two new metrics --------- Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> Co-authored-by: Kerollmops <clement@meilisearch.com> --------- Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> Co-authored-by: Clément Renault <clement@meilisearch.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> Co-authored-by: Clément Renault <renault.cle@gmail.com> Co-authored-by: Tamo <tamo@meilisearch.com>
This was referenced Aug 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 API Diff
Summary
Describes the new index setting that gives the ability to customize a facet sort order
Changes
sortFacetValuesBysettingOut Of Scope
N/A
Attention To Reviewers
N/A
Misc