Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash in matching_polyfill for earlier (implicit_transitive_deps false) implementation #1262

Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix: crash in matching_polyfill for earlier (implicit_transitive_deps false) implementation #1262

merged 2 commits into from
Dec 23, 2024

Conversation

anmonteiro
Copy link
Member

No description provided.

@anmonteiro anmonteiro changed the title test a fix fix: crash in matching_polyfill for earlier (implicit_transitive_deps false) implementation Dec 22, 2024
@anmonteiro anmonteiro marked this pull request as ready for review December 22, 2024 06:56
@anmonteiro
Copy link
Member Author

I spent some time trying to manufacture a test that would fail with this fix.

My current thoughts are:

  • the crash was observed when trying to augment the pattern matching blocks with the constructor names for variants
  • it was only observed under the old (currently sorta broken on OCaml < 5.2) (implicit_transitive_deps false) implementation
  • in the current implementation, we will crash later than this matching polyfill code if there's actually a dependency missing.

@anmonteiro anmonteiro merged commit 9784de5 into main Dec 23, 2024
5 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/test-fix branch December 23, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anmonteiro