Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash in matching_polyfill for earlier (implicit_transitive_deps false) implementation #1262

Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix: crash in matching_polyfill for earlier (implicit_transitive_deps false) implementation #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ecbc02
test a fix
anmonteiro Dec 21, 2024
be95738
chore: add changelog entry
anmonteiro Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ Unreleased
- A new alert `melsend` has been added to the PPX (which warns by default)
and can be turned into an error with `melange.ppx -alert ++melsend` once
[ocaml/dune#11234](https://github.com/ocaml/dune/pull/11234) lands.
- core: fix a crash related to finding constructor names in pattern matching triggered by dune's earlier implementation of `(implicit_transitive_deps false)`
([#1238](https://github.com/melange-re/melange/pull/1238),
[#1262](https://github.com/melange-re/melange/pull/1262))

4.0.1 2024-06-07
---------------
Expand Down
1 change: 1 addition & 0 deletions jscomp/core/matching_polyfill.cppo.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ let names_from_construct_pattern
in
let rec resolve_path n path =
match Env.find_type path pat.pat_env with
| exception Not_found -> None
| { type_kind = Type_variant (cstrs, _repr); _ } ->
names_from_type_variant cstrs
| { type_kind =
Expand Down
5 changes: 0 additions & 5 deletions test/blackbox-tests/persistent-structure-error.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,3 @@ The issue seems to happen due to a combination of two things:
$ melc --bs-package-output inner -o inner/inner.cmj -c inner/inner.ml
$ melc -I inner --bs-package-output outer -o outer/outer.cmj -c outer/outer.ml --bs-stop-after-cmj
$ melc -I outer --bs-package-output . -o main.cmj -c main.ml --bs-stop-after-cmj
melc: internal error, uncaught exception:
Not_found

[125]

Loading