Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use partitionKey from context in FixedWindowDynamoDB #104

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mennanov
Copy link
Owner

@mennanov mennanov commented Dec 5, 2024

Add support for the partitionKey in the FixedWindowDynamoDB backend to be provided per-request:

window.Limit(l.NewFixedWindowDynamoDBContext(context.Background(), "anotherPartitionKey"))

Resolves #89

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (d0f9793) to head (1a725ff).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   81.23%   81.06%   -0.18%     
==========================================
  Files          12       12              
  Lines        1711     1716       +5     
==========================================
+ Hits         1390     1391       +1     
- Misses        245      248       +3     
- Partials       76       77       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mennanov mennanov force-pushed the dynamo_partition_key_fixedwindow branch from 1a725ff to 805355f Compare December 5, 2024 23:36
@mennanov mennanov merged commit fe1d526 into master Dec 10, 2024
4 checks passed
@mennanov mennanov deleted the dynamo_partition_key_fixedwindow branch December 10, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow partition key to be passed as a parameter
2 participants