[pull] main from hashicorp:main #5
Open
+95,368
−32,807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
We can't enforce the check of the close flag in mocked ephemeral resources, since multiple instances could call the close method while other instances are running.
The cloud backend includes a retry hook that relies on a go-tfe implementation. Since these retry messages were not rendered through a view, the `-json` flag was not respected, leading to mixed (non-pure JSON) output in the terminal whenever retry messages were printed. Before passing the init view to the cloud backend, we ensure the retryLog hook is included in the init view. Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
Ephemeral instances are only removed as whole resources, so there should not be missing instances from an ephemeral resource. We can't error on missing instances, because evaluation of checks may be pulling only a single instance for evaluation before other sibling instances have been opened.
Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>
…checkable add discrete codepaths for ephemeral apply nodes
Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
…35938) Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
The cloud view is responsible for rendering messages related to cloud operations, presenting them to the user in either a human-readable format or as JSON output in the terminal. Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
…based on view type. Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
As LLM tools are increasingly used as a code development assistance tool, it will be helpful to have the information of how configurations are generated. This can be used to give feedback to the toolmakers regarding hallucinations.
Add LLM info request to the bug report form
…tion Skip graph cycle validation when using the graph command
we might need them later on, but it will be easier to find the right place and abstraction when the need to use them arises
we got the marks from the proposed value, the provider gets the value without the marks we then reapply the marks and need to also remove the write-only values by setting the values to null
we allow it for all requests
The allowed use cases for ephemeral variables was left out of the ephemeral variables page. Copied the corresponding lines from ephemeral resources.
Move to a tagged released.
* Attempt to remove flaky parts of the equivalence testing * use new version to fix this * update with latest terraform
missing ephemeral variable docs
update go-cty to a tagged release
ephemeral: support write-only attributes
The design of Terraform inherently can create cycles for replacement across providers, and the interim solution was to simply check for any cycles to skip these dependencies. Checking the entire graph for each connection was a bit silly, but doesn't have any problems for most configurations. This is quadratic though, so extremely large numbers of interdependent replacement ops may slow down to the point of making a plan impossible. While we don't have a solution for configuring the provider out of band, or quickly checking the provider dependencies as noted in the FIXME, we can do nearly the same thing just by making sure our `from` node isn't already an ancestor of the `to`, essentially preemptively checking for the cycle.
* Bump golang.org/x/crypto from 0.27.0 to 0.31.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.31.0. - [Commits](golang/crypto@v0.27.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * syncdeps --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>
core: simplify cycle check for inter-provider deps
Terraform always attempts to generate a plan even when encountering an error, so we need to ensure that all plan elements have valid values to store and inspect later. Ensuring that `Changes.Encode` always returns a valid value avoids the need for nil checks elsewhere while returning an error to the user.
encoding of changes should always return a value
Bucket and key were inconsistent with the doc content
Update sample bucket names on s3.mdx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )