Add New PFPS #71
Add New PFPS #71
Conversation
i did what i had to, and that is shrink some of em |
Deploying with
|
| Latest commit: |
633021e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6f366592.meower-svelte.pages.dev |
| Branch Preview URL: | https://showier-addpfp-2.meower-svelte.pages.dev |
showierdata9978
dismissed
qbjl’s stale review
i did what i had to, and that is shrink some of em. or it would not fit.
|
Because meower svelte does not have the newer BetterMeower pfps, this pr makes meower svelte pfps incompatible with BetterMeower and vice versa. |
BM is not active, so it really does not matter, if you want to do this then make a pr to this branch |
It does matter, because when it becomes active again (after CL4 port), it will break a lot. According to tnix, CL4 svelte will be done by the end of January. |
|
No you need to fix the issue in this branch |
|
@CST1229 what do you think of above, i don't see it as important. because bm pfps cant be seen or selected rn anyway. Josh can add the pfps if he wants do but idc about doin it myself |
Well then that will break Meower Svelte, because BetterMeower pfps show as the new pfps, it is important. |
BM is your client; it's not my job to have compatibility with it. Even more so I don't even have the BM pfps |
I can send you the BetterMeower pfps, there are 5. |
|
|
No, that won't work, the PFP picker is not going to show them. I am not adding an additional week of stress to my already cluttered and stressful holidays to make it work either. |
|
Maybe we should just decide on all of the default pfps we're going to have in CL4 port and later and then just don't change them. Custom pfps will be a thing in CL4 port and later, so it doesn't make much sense to keep adding more and more default pfps. |
|
we should have like a few default pfps which in reality set your custom pfp .png data to that image. once cl4 port, bettermeower pfps will not break and will instead just show a .png of the user instead of a pfp_data int |
|
nah, since most of the default pfps are SVGs |
|
This pr is for 1.6 |
|
That would work perfectly, because then I can add BetterMeower pfps and not have them break svelte. (edit why did it not quote cst) |
Default pfps used in Meower Svelte shouldn't be file uploads though, since most are SVGs and will use a ton of bandwidth uploading default pfps. The current way I have it in CL4 port is pfps/icons have 2 properties, 1 for the type and 1 for the data, type can either be 0 for default pfp or 1 for custom pfp, then data is either like it is now for default pfps or a partial upload object for custom pfps. |
|
It's svgs because of scratch |
And why should it not be an SVG in svelte? It's far higher quality than a PNG or JPEG. Also we have to keep compatibility with Scratch throughout CL4 port. |
Yeah ik, also svgs fail to render on gh for meh |
We could also add an option for a PFP URL. |
Or use gravatar |
|
Why is this PR still blocked. the issue has been resolved. and the thing being discussed is not the point of this PR |
i forgot |
|
kinda nitpicking here, this pfp could be made larger (making the meowy about the same size as the others) |
|
That one is sticking out; if I did not change it's size it would look odd
…On Mon, Jan 16, 2023, 11:12 PM CST1229 ***@***.***> wrote:
kinda nitpicking here, this pfp could be made larger (making the meowy
about the same size as the others)
[image: image]
<https://user-images.githubusercontent.com/68464103/212815263-a4a775a6-c931-4b8c-afe2-a0468c6671a3.png>
—
Reply to this email directly, view it on GitHub
<#71 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQHW4P43W7OM5UPWLTNDA4TWSYS5RANCNFSM6AAAAAATXGKFFY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
t-mobile |
telstra better |
|
might close this PR because we do not need a full page of default profile pictures when APIv1/CL4 port/Beta 6 is honestly around the corner, which will have profile picture upload support. i don't care about the support of the old scratch clients as no one really uses them anyways and they're going to be depreciated soon. we should not add more default profile pictures until Beta 6, and users don't need another 20 profile pictures anyway. if you dislike my thoughts go ahead and complain about it, but this PR just doesn't make sense due to future features. |
I did the opposite of that |
i wish you can react the skull emoji |
t-mobile gets a data breach almost every day |
cl4 is a month away, maybe 2. I think its fair to add more meowy pfps |
tnix says it's going to be released at the end of the this month, so, it's a week away, not a month |
|
After then, it is still a month away bc of rewrites, that are needed
…On Wed, Jan 25, 2023, 9:56 AM M.D. Walters ***@***.***> wrote:
cl4 is a month away
tnix says it's going to be released at the end of the this month, so, it's
a week away, not a month
—
Reply to this email directly, view it on GitHub
<#71 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQHW4P2DPGQSNLK3VNIKJ43WUFEK7ANCNFSM6AAAAAATXGKFFY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
ok
|
No it's not, it's already finished. Just waiting on CL4 port Svelte, which is planned to be done by the end of the month |
yeah, i think im going to close this. |
|
This is cst's project tho, so |
It's mostly done, I would say it's stable (up until today where I broke user sessions and CL events, sorry). Right now it's just adding features and cleaning up code/API endpoints. Tomorrow it'll be back in a stable state and can start to be implemented into clients. The beta server is delayed a bit, and Idk when it'll be out. |
|
And iv already implemented the new PFPs into SvelteKit. so if the pfps are not added, a official client does not have support lmao |
it’s a pull request… |
Im talking about Meower-Svelte |
Same with BetterMeower, except the Meower Svelte team chose to add BetterMeower pfps, NOT while trying to merge a whole new release. |
closes #62
successor to #64