Addressed PR review feedback

merbanan · Jan 21, 2023 · d145440 · d145440
1 parent 93578c1
commit d145440
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -306,6 +306,7 @@ See [CONTRIBUTING.md](./docs/CONTRIBUTING.md).
  [221] Fine Offset Electronics WN34 temperature sensor
  [222] Rubicson Pool Thermometer 48942
  [223] Badger ORION water meter, 100kbps (-f 916450000 -s 1200000)
+ [224] TFA Dostmann 14.1504.V2 Radio-controlled grill and meat thermometer
 
 * Disabled by default, use -R n or a conf file to enable
 

diff --git a/conf/rtl_433.example.conf b/conf/rtl_433.example.conf
@@ -445,6 +445,7 @@ stop_after_successful_events false
  protocol 221 # Fine Offset Electronics WN34 temperature sensor
  protocol 222 # Rubicson Pool Thermometer 48942
  protocol 223 # Badger ORION water meter, 100kbps (-f 916450000 -s 1200000)
+ protocol 224 # TFA Dostmann 14.1504.V2 Radio-controlled grill and meat thermometer
 
 ## Flex devices (command line option "-X")
 

diff --git a/src/devices/tfa_14_1504_v2.c b/src/devices/tfa_14_1504_v2.c
@@ -52,9 +52,7 @@ Example payloads (excluding preamble):
 static int tfa_14_1504_v2_callback(r_device *decoder, bitbuffer_t *bitbuffer)
 {
  uint8_t const preamble[] = {
- 0xaa,
- 0xaa,
- 0x5c,
+ 0xaa, 0xaa, 0x5c,
  };
 
  if (bitbuffer->num_rows != 1) {
@@ -105,7 +103,7 @@ static int tfa_14_1504_v2_callback(r_device *decoder, bitbuffer_t *bitbuffer)
  // we discard the last 2 bits as those are always zero
  uint16_t raw_temp_c = ((data[0] & 0xf) << 6) + (data[1] >> 2);
  unsigned is_probe_connected = (raw_temp_c != 0x1c0);
- double temp_c = ((int)raw_temp_c) - 532;
+ float temp_c = ((int)raw_temp_c) - 532;
 
  /* clang-format off */
  data_t *output = data_make(