Bump node.js from 13.6 to 14.16 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently building the docker image fails with the following error: ``` => [mermaid-live-editor-builder 4/5] RUN yarn install 25.2s= => ERROR [mermaid-live-editor-builder 5/5] RUN yarn build 0.8s ------ > [mermaid-live-editor-builder 5/5] RUN yarn build: mermaid-js#9 0.399 yarn run v1.21.1 mermaid-js#9 0.432 $ webpack build mermaid-js#9 0.748 internal/modules/cjs/loader.js:628 mermaid-js#9 0.748 throw e; mermaid-js#9 0.748 ^ mermaid-js#9 0.748 mermaid-js#9 0.748 Error: No valid exports main found for '/home/node_modules/colorette' mermaid-js#9 0.748 at resolveExportsTarget (internal/modules/cjs/loader.js:625:9) mermaid-js#9 0.748 at applyExports (internal/modules/cjs/loader.js:502:14) mermaid-js#9 0.748 at resolveExports (internal/modules/cjs/loader.js:551:12) mermaid-js#9 0.748 at Function.Module._findPath (internal/modules/cjs/loader.js:657:22) mermaid-js#9 0.748 at Function.Module._resolveFilename (internal/modules/cjs/loader.js:960:27) mermaid-js#9 0.748 at Function.Module._load (internal/modules/cjs/loader.js:855:27) mermaid-js#9 0.748 at Module.require (internal/modules/cjs/loader.js:1033:19) mermaid-js#9 0.748 at require (/home/node_modules/v8-compile-cache/v8-compile-cache.js:159:20) mermaid-js#9 0.748 at Object.<anonymous> (/home/node_modules/webpack-cli/lib/webpack-cli.js:10:66) mermaid-js#9 0.748 at Module._compile (/home/node_modules/v8-compile-cache/v8-compile-cache.js:192:30) { mermaid-js#9 0.748 code: 'MODULE_NOT_FOUND' mermaid-js#9 0.748 } mermaid-js#9 0.763 error Command failed with exit code 1. mermaid-js#9 0.763 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ------ executor failed running [/bin/sh -c yarn build]: exit code: 1 ``` This is because colorette doesn't work with Node.js 13: jorgebucaran/colorette#46 Any node.js other than 13 would work. If there's a reason to not use the latest version, we can change it to 14.16.
|
I think going with LTS (v14) will be a better choice as we are not using any v15 specific features. |
gukoff
changed the title
|
Changed, verified it builds and runs. |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Currently building the docker image fails with the following error:
This is because colorette doesn't work with Node.js 13: jorgebucaran/colorette#46
📏 Design Decisions
I bumped the node.js version to the latest.
Any node.js other than 13 would work. If there's a reason to not use the latest version, we can use 14.16.
📋 Tasks
Make sure you
masterbranch