Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge back v4.11.0 to develop #6032

Merged
merged 34 commits into from
Nov 7, 2024
Merged

Merge back v4.11.0 to develop #6032

merged 34 commits into from
Nov 7, 2024

Conversation

ashishjain0512
Copy link
Collaborator

📑 Summary

Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

huynhicode and others added 30 commits October 18, 2024 09:54
Remove Product Hunt promos & Update Promo bar
Exclude the `node.shape` type from `kanbanItem()`, as otherwise it
causes a circular dependency in the types.
Add the appropriate type checks to ensure that we're only ever calling:

- `insertCluster()` with `ClusterNode`
- `insertNode()` with a `NonClusterNode`

Fixes: 7401cb8
This snapshot should have been modified in
c1ca351 (Fix (tmp) for handling of config of htmlLabels ion note. MOvint class box out of flowchart docs, 2024-10-30

Fixes: c1ca351
This isn't documented, but apparently changesets supports this in changesets/changesets@91d1ef2

This is needed to give @yari-dewalt credit for PR #5880
Copy link

changeset-bot bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: f507dbb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit f507dbb
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/672caaf70bbc00000840f96e
😎 Deploy Preview https://deploy-preview-6032--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 7, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@6032
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6032
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6032
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6032

commit: f507dbb

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0.39748% with 3007 lines in your changes missing coverage. Please review.

Project coverage is 4.49%. Comparing base (be57484) to head (f507dbb).
Report is 217 commits behind head on develop.

Files with missing lines Patch % Lines
...id/src/rendering-util/rendering-elements/shapes.ts 0.00% 504 Missing ⚠️
packages/mermaid/src/diagrams/kanban/kanbanDb.ts 0.00% 253 Missing ⚠️
packages/mermaid/src/diagrams/class/classDb.ts 0.00% 238 Missing ⚠️
packages/mermaid/src/diagrams/class/shapeUtil.ts 0.00% 223 Missing ⚠️
...ndering-util/rendering-elements/shapes/classBox.ts 0.00% 207 Missing ⚠️
...ering-util/rendering-elements/shapes/kanbanItem.ts 0.00% 163 Missing ⚠️
.../src/rendering-util/rendering-elements/clusters.js 0.00% 119 Missing ⚠️
...c/rendering-util/rendering-elements/shapes/util.ts 0.00% 113 Missing ⚠️
packages/mermaid/src/diagrams/kanban/styles.ts 0.00% 109 Missing ⚠️
...ages/mermaid/src/diagrams/kanban/kanbanRenderer.ts 0.00% 96 Missing ⚠️
... and 83 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6032      +/-   ##
==========================================
- Coverage     4.67%   4.49%   -0.18%     
==========================================
  Files          372     383      +11     
  Lines        51669   53925    +2256     
  Branches       611     596      -15     
==========================================
+ Hits          2414    2425      +11     
- Misses       49255   51500    +2245     
Flag Coverage Δ
unit 4.49% <0.39%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/defaultConfig.ts 45.38% <100.00%> (+0.61%) ⬆️
...ackages/mermaid/src/docs/.vitepress/theme/index.ts 0.00% <ø> (ø)
...aid/src/rendering-util/rendering-elements/edges.js 0.00% <ø> (ø)
.build/jsonSchema.ts 0.00% <0.00%> (ø)
...ages/mermaid/src/diagrams/class/classDiagram-v2.ts 0.00% <0.00%> (ø)
...ackages/mermaid/src/diagrams/class/classDiagram.ts 0.00% <0.00%> (ø)
packages/mermaid/src/rendering-util/createText.ts 0.00% <0.00%> (ø)
...s/mermaid/src/diagram-api/diagram-orchestration.ts 0.00% <0.00%> (ø)
packages/mermaid/src/docs/.vitepress/config.ts 0.00% <0.00%> (ø)
...mermaid/src/rendering-util/handle-markdown-text.ts 0.00% <0.00%> (ø)
... and 86 more

... and 1 file with indirect coverage changes

Copy link

argos-ci bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 9 changed, 340 added, 339 removed Nov 7, 2024, 12:07 PM

@ashishjain0512 ashishjain0512 added this pull request to the merge queue Nov 7, 2024
Merged via the queue into develop with commit c218e36 Nov 7, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants