Allow for update of connector status #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianadoherty
force-pushed
the
update-connector-status
branch
2 times, most recently
from
22214c4
to
81d1f57
Compare
dianadoherty
force-pushed
the
update-connector-status
branch
from
81d1f57
to
991c34a
Compare
dianadoherty
requested review from
a team,
terrancej,
ahmeroxa and
raulb
and removed request for
a team
raulb
reviewed
Mar 5, 2021
| defer cancel() | ||
|
|
||
| // update connector status with name | ||
| con, err := c.UpdateConnectorStatus(ctx, conName, state) |
There was a problem hiding this comment.
In other actions we've been providing feedback to the user when these are being initiated (i.e.: "Creating connector..."). Here's an example: https://github.com/meroxa/cli/pull/63/files#diff-711a4354cb9e88f469f82742ba63b8b9abc7a40b99dd9c090f78cda73377774aR79-R81.
What do you think @dianadoherty ?
There was a problem hiding this comment.
Sounds good, updated it!
raulb
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
Looks great aside a comment regarding (maybe) providing some feedback to the user when an action is being performed. I'm aware we're being inconsistent on this, but I think we should follow the same pattern everywhere.
Either way, once it's rebased this should be good to go.
dianadoherty
force-pushed
the
update-connector-status
branch
from
991c34a
to
231d086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
As part of work to pause/resume/restart connectors, we want to be able to call the new API endpoint for updating the connector status
https://github.com/meroxa/platform-api/blob/fe4b68fcfaac0fa125f67fb6803ae4f182b075ba/cmd/api/router/router.go#L29
Fixes https://meroxa.atlassian.net/browse/PLATFORM-43
Depends on: https://github.com/meroxa/meroxa-go/pull/15
Type of change
How was this tested?
Additional references
Any additional links (if appropriate)
Documentation updated
Make sure that our documentation is accordingly updated when necessary.
Provide link: