Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add more details screen for nodes #1176

Closed
wants to merge 3 commits into from
Closed

feat: Add more details screen for nodes #1176

wants to merge 3 commits into from

Conversation

jamesarich
Copy link
Contributor

@jamesarich jamesarich commented Aug 1, 2024 •
edited
Loading

This commit introduces a new "More Details" screen for nodes, accessible via the node chip's context menu.
image Screenshot_20240801_125524 (1)

@jamesarich
feat: Add more details screen for nodes
b90f614 
This commit introduces a new "More Details" screen for nodes, accessible via the node list's context menu.

The screen displays the node's long name and provides a back button to return to the node list.
This feature allows users to view additional information about individual nodes.
@jamesarich
feat: Sets background and content colors of the app bar.
7615066
@jamesarich
Refactor: Use nodeDBbyNum to get node by number
3241a50 
This commit refactors the getNodeByNum function to use the in memory nodeDBbyNum map instead
 of iterating through the nodeList. This improves performance and readability.
@Robert-0410
Copy link
Contributor

I'm going to start working on this feature, would it be best to open a pull request to this branch? Or should I just open a new pull request when I have something working?

@jamesarich
Copy link
Contributor Author

I'm going to start working on this feature, would it be best to open a pull request to this branch? Or should I just open a new pull request when I have something working?

Whichever works, you should be able to add my fork as a git remote and pull in the branch to get started.

@Robert-0410
Copy link
Contributor

I'm going to start working on this feature, would it be best to open a pull request to this branch? Or should I just open a new pull request when I have something working?

Whichever works, you should be able to add my fork as a git remote and pull in the branch to get started.

Awesome, got that going already thanks.

@andrekir
Copy link
Member

implemented in #1198

@andrekir andrekir closed this Aug 31, 2024
@jamesarich jamesarich deleted the node_details_screen branch October 8, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrekir andrekir andrekir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesarich @Robert-0410 @andrekir