Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Charts #1198

Merged
merged 21 commits into from
Aug 31, 2024
Merged

Initial Charts #1198

merged 21 commits into from
Aug 31, 2024

Conversation

Robert-0410
Copy link
Contributor

Issue #559 seems relevant to this Pull Request.

I've implemented a first graph/chart for the device metrics as a start.

My plan is to address any valuable input anyone may have and based on those improvements we can plan the next steps.

My Concerns

  • Anything wrong with the way I got the data?

Note: The data used for the chart below is not real.

Screenshot_20240817-141800_Meshtastic

jamesarich and others added 7 commits August 1, 2024 12:48
@jamesarich
feat: Add more details screen for nodes
b90f614 
This commit introduces a new "More Details" screen for nodes, accessible via the node list's context menu.

The screen displays the node's long name and provides a back button to return to the node list.
This feature allows users to view additional information about individual nodes.
@jamesarich
feat: Sets background and content colors of the app bar.
7615066
@jamesarich
Refactor: Use nodeDBbyNum to get node by number
3241a50 
This commit refactors the getNodeByNum function to use the in memory nodeDBbyNum map instead
 of iterating through the nodeList. This improves performance and readability.
@Robert-0410
Merge branch 'meshtastic:master' into graphs
8a15143
@Robert-0410
Merge branch 'graphs' of github.com:Robert-0410/Meshtastic-Android in…
931d064 
…to graphs
@Robert-0410
Implementation of a first DeviceMetrics chart.
20daa95
@Robert-0410
Merge branch 'meshtastic:master' into graphs
a849b6a
andrekir
andrekir reviewed Aug 18, 2024
View reviewed changes
Copy link
Member

@andrekir andrekir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. added a few notes to improve how the data is handled.

app/src/main/java/com/geeksville/mesh/ui/NodeDetailsFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/com/geeksville/mesh/model/UIState.kt Outdated Show resolved Hide resolved
@Robert-0410
Copy link
Contributor Author

I'm going to move forward with the Environmental Metrics chart. I was thinking about using a Pager that allows the user to swipe between graphs. Let me know if that works or if anyone has another suggestions.

@jamesarich
Copy link
Contributor

jamesarich commented Aug 21, 2024 •
edited
Loading

I'm going to move forward with the Environmental Metrics chart. I was thinking about using a Pager that allows the user to swipe between graphs. Let me know if that works or if anyone has another suggestions.

nice progress - Pager w/ tabs or similar controls probably makes sense here. Found some guidelines (material 2 but seems relevant).

@Robert-0410
Copy link
Contributor Author

I'm going to move forward with the Environmental Metrics chart. I was thinking about using a Pager that allows the user to swipe between graphs. Let me know if that works or if anyone has another suggestions.

nice progress - Pager w/ tabs or similar controls probably makes sense here. Found some guidelines (material 2 but seems relevant).

Thanks, cool guide had not seen that yet.

@andrekir
Copy link
Member

I'm going to move forward with the Environmental Metrics chart. I was thinking about using a Pager that allows the user to swipe between graphs. Let me know if that works or if anyone has another suggestions.

sounds good.

I'd suggest working with protobufs directly instead of our POJOs (ie. com.geeksville.mesh.TelemetryProtos.EnvironmentMetrics instead of com.geeksville.mesh.EnvironmentMetrics)

as the POJOs will always behind (sometimes not available at all) for some telemetry variants.

@Robert-0410
Copy link
Contributor Author

I'm going to move forward with the Environmental Metrics chart. I was thinking about using a Pager that allows the user to swipe between graphs. Let me know if that works or if anyone has another suggestions.

sounds good.

I'd suggest working with protobufs directly instead of our POJOs (ie. com.geeksville.mesh.TelemetryProtos.EnvironmentMetrics instead of com.geeksville.mesh.EnvironmentMetrics)

as the POJOs will always behind (sometimes not available at all) for some telemetry variants.

Makes sense.

@Robert-0410 Robert-0410 marked this pull request as ready for review August 25, 2024 01:09
@Robert-0410
Copy link
Contributor Author

The first iterations of graphs are ready for review. They still have room to improve but I would say its useful in it's current state.

@andrekir andrekir linked an issue Aug 25, 2024 that may be closed by this pull request
[Feature request] Telemetry / Device Metrics Log #559
Closed
andrekir
andrekir reviewed Aug 25, 2024
View reviewed changes
Copy link
Member

@andrekir andrekir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few notes but overall looks good!

app/src/main/java/com/geeksville/mesh/model/NodeDetailsViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/com/geeksville/mesh/ui/NodeDetailsFragment.kt Show resolved Hide resolved
app/src/main/java/com/geeksville/mesh/ui/NodeDetailsFragment.kt Outdated Show resolved Hide resolved
@andrekir andrekir merged commit 9f136fb into meshtastic:master Aug 31, 2024
5 checks passed
@andrekir andrekir mentioned this pull request Aug 31, 2024
Closed
@Robert-0410 Robert-0410 deleted the graphs branch September 17, 2024 02:45
@DOC-HOC
Copy link

DOC-HOC commented Sep 20, 2024 •
edited
Loading

Hi @Robert-0410,

How about adding the following features to the Device Metrics?

  • Changeable timeframe: i.e. choose between history of one day, 3 days, one week of history
  • choose what should be displayed: i.e. checkboxes for each sensor so you can unselect battery voltage and would see Channel and Air utilization with a better resolution
  • add position to the history, ideally with a map and a track on it

Thanks,
Chris

danwelch3 pushed a commit to danwelch3/meshtastic-android that referenced this pull request Oct 3, 2024
@Robert-0410 @danwelch3
feat: Telemetry charts (meshtastic#1198)
c82a777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrekir andrekir andrekir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] Telemetry / Device Metrics Log
5 participants
@Robert-0410 @jamesarich @andrekir @DOC-HOC @thebentern