Ensure the MQTT address is an IPv4 before determining it's private

src/mqtt/MQTT.cpp

@@ -704,26 +704,34 @@ bool MQTT::isValidJsonEnvelope(JSONObject &json)
            (json.find("payload") != json.end());                            // should have a payload
 }
 
-bool MQTT::isPrivateIpAddress(const char ip[])
+bool MQTT::isPrivateIpAddress(const char address[])
 {
+    // Ensure the address contains only digits and dots.
+    // Even if it's not a valid IP address, we will know it's not a domain.
+    for (int i = 0; i < strlen(address); i++) {
+        if (!isdigit(address[i]) && address[i] != '.') {
+            return false;
+        }
+    }
+
     // Check the easy ones first.
-    if (strcmp(ip, "127.0.0.1") == 0 || strncmp(ip, "10.", 3) == 0 || strncmp(ip, "192.168", 7) == 0) {
+    if (strcmp(address, "127.0.0.1") == 0 || strncmp(address, "10.", 3) == 0 || strncmp(address, "192.168", 7) == 0) {
         return true;
     }
 
     // See if it's definitely not a 172 address.
-    if (strncmp(ip, "172", 3) != 0) {
+    if (strncmp(address, "172", 3) != 0) {
         return false;
     }
 
     // We know it's a 172 address, now see if the second octet is 2 digits.
-    if (ip[6] != '.') {
+    if (address[6] != '.') {
         return false;
     }
 
     // Copy the second octet into a secondary buffer we can null-terminate and parse.
     char octet2[3];
-    strncpy(octet2, ip + 4, 2);
+    strncpy(octet2, address + 4, 2);
     octet2[2] = 0;
 
     int octet2Num = atoi(octet2);

src/mqtt/MQTT.h

@@ -120,9 +120,9 @@ class MQTT : private concurrency::OSThread
     // returns true if this is a valid JSON envelope which we accept on downlink
     bool isValidJsonEnvelope(JSONObject &json);
 
-    /// Determines if the given IP address is a private address, i.e. not routable on the public internet.
+    /// Determines if the given address is a private IPv4 address, i.e. not routable on the public internet.
     /// These are the ranges: 127.0.0.1, 10.0.0.0-10.255.255.255, 172.16.0.0-172.31.255.255, 192.168.0.0-192.168.255.255.
-    bool isPrivateIpAddress(const char ip[]);
+    bool isPrivateIpAddress(const char address[]);
 
     /// Return 0 if sleep is okay, veto sleep if we are connected to pubsub server
     // int preflightSleepCb(void *unused = NULL) { return pubSub.connected() ? 1 : 0; }