Ensure the MQTT address is an IPv4 before determining it's private #5081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…determining it's private.
|
@jp-bennett @fifieldt Next iteration is here. :) |
fifieldt
approved these changes
Oct 16, 2024
fifieldt
reviewed
Oct 16, 2024
jp-bennett
approved these changes
Oct 16, 2024
We could. I opted not to initially for the same reason of just checking for digits and dots: even if it's not valid, a connection won't be made. It's easy enough though, so I can if you want. |
|
Ok, length check added. 😅 |
fifieldt
approved these changes
Oct 16, 2024
thebentern
approved these changes
Oct 16, 2024
|
I have to add a non-standard port number (like 192.168.1.84:2883) and the detection is not detecting it as a private IP anymore. |
@CamFlyerCH yep, I realized that earlier. The fix is in #5084. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #5072, ensuring no sneaking subdomains make an address appear like a private IPv4.
This is also now tested. :)