-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Mute: channels #7957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mute: channels #7957
Conversation
… 7943-mute-target
|
There are two things left to be done here:
I'm currently lacking the hardware to do this, I have some on the way but it's unlikely it will be here any time soon. If this PR is approved I will open a new issue for these TODOS which someone else can take up in the meantime - otherwise, I will do it when I have the hardware. |
|
Channels is fine, nodes is kind of a duplication of the existing ignore functionality. |
|
Apologies, didn't mean to close/reopen. @garthvh Happy to make changes, but I think it's worth considering that unlike ignore - the message is still delivered and can be read.
|
|
After a discussion with @garthvh this morning; we've determined the best course of action here is to decouple muting nodes and muting channels into two seperate PR's. This is to relieve pressure on the size constraint of the user proto - which currently hangs a big question mark over the ability to merge this. |
Resolves #7943
Introduces mechanisms to mute message notifications received over specified channels.
When a message is received over a muted channel, the device's buzzer (if present) should not be activated. Drawing of any alert UI notification to the device's screen should also be blocked.
The exception to this is bell alerts (when activated), which should still sound the buzzer and display a notification.
Protobuf changes: meshtastic/protobufs#769
Docs: meshtastic/meshtastic#2028
🤝 Attestations