Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph Infrastructure Refresh #456

Merged
merged 45 commits into from
Mar 12, 2024
Merged

Graph Infrastructure Refresh #456

merged 45 commits into from
Mar 12, 2024

Conversation

ajmcquilkin
Copy link
Member

@ajmcquilkin ajmcquilkin commented Mar 1, 2024 •
edited
Loading

This PR is a complete rewrite of the existing graph infrastructure. This feature branch makes the following changes:

  • Removes all deprecated graph infrastructure
  • Refactors IPC handling to simplify DX on frontend
  • Updates logging to use tauri-plugin-log
  • Adds backend graph management infrastructure using petgraph
  • Refactors the MapView to use the new graph infrastructure as its source of truth
  • Hid nodes without GPS from the map
  • Implemented neighbor info spec into graph infrastructure
  • Implemented working node and edge timeout based on incoming neighbor info packets
  • Adds a new "Graph Debugger" sidebar tab

This PR replaces #434.

image

@ajmcquilkin
Compiling removal of graph
c123844
@ajmcquilkin
Removed unnecessary submodule
cdb04e0
@ajmcquilkin
Clarified panic calls
109c203
@ajmcquilkin
Updated UI to reflect backend code changes
ffc7367
@ajmcquilkin
Merge pull request #448 from meshtastic/graph/deprecated-code-removal
9d68672 
Remove non-functional graph infrastructure
@ajmcquilkin
Refactored invoke calls into api functions (non-functional)
8b26319
@ajmcquilkin
Removed redux saga
d87ceb8
@ajmcquilkin
Removed unused listeners
d5a618e
@ajmcquilkin
Merge pull request #449 from meshtastic/graph/refactor-ui-handlers
f05195e 
Simplified UI data management infra
@ajmcquilkin
Integrated tauri plugin log
48210e7
@ajmcquilkin
Merge pull request #450 from meshtastic/graph/logging-update
cd71a29 
Updated logging
@ajmcquilkin
Refactored packet handler into mesh packet api struct
1c6ebe8
@ajmcquilkin
Added graph Tauri state management
5bfa893
@ajmcquilkin
Implemented graph get command
c8af109
@ajmcquilkin
Moved side effects handlers into packet api
567dc57
@ajmcquilkin
Added TODO for grpah regen on node info packet
b0149aa
@ajmcquilkin
Wired graph routing infrastructure
04db327
@ajmcquilkin
Updated version of meshtastic lib
a734559
@ajmcquilkin
Added graph node and graph edge definitions
7959742
@ajmcquilkin
Added graph node and graph edge definitions
9928351
@ajmcquilkin
Added MVP graph generation and visualization
cc60c36
@ajmcquilkin
Merge branch 'graph/integrate-graph' of https://github.com/meshtastic…
baf53a2 
…/network-management-client into graph/integrate-graph
@ajmcquilkin
Merge branch 'main' of https://github.com/meshtastic/network-manageme…
815da85 
…nt-client into graph/integrate-graph
@ajmcquilkin
Merge pull request #452 from meshtastic/graph/integrate-graph
3f52ff3 
Graph/integrate graph
@ajmcquilkin
Merge branch 'reimplement-graph-infra' of https://github.com/meshtast…
e78b40b 
…ic/network-management-client into reimplement-graph-infra
@ajmcquilkin
Moved graph infra into dedicated backend handlers
af4aafa
@ajmcquilkin
Added graph update event listeners
09738d5
@ajmcquilkin
Updated map view to use graph as source of truth
77b06ba
@ajmcquilkin
Updated graph to serve as map source of truth
7409f56
@ajmcquilkin
Added graph timeout handling
6318646
@ajmcquilkin ajmcquilkin requested a review from sachaw March 1, 2024 21:11
@ajmcquilkin ajmcquilkin self-assigned this Mar 1, 2024
sachaw
sachaw previously approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@sachaw sachaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

biome.json Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Mar 7, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ajmcquilkin ajmcquilkin requested a review from sachaw March 7, 2024 03:01
This was referenced Mar 7, 2024
Open
Open
@ajmcquilkin ajmcquilkin merged commit c8b6360 into main Mar 12, 2024
15 checks passed
@ajmcquilkin ajmcquilkin deleted the reimplement-graph-infra branch March 12, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachaw sachaw sachaw approved these changes

@garthvh garthvh Awaiting requested review from garthvh

@jp-bennett jp-bennett Awaiting requested review from jp-bennett

@thebentern thebentern Awaiting requested review from thebentern

@GUVWAF GUVWAF Awaiting requested review from GUVWAF

Assignees

@ajmcquilkin ajmcquilkin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajmcquilkin @CLAassistant @sachaw