Add BatchGetTraversableTest and update CHANGELOG #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new test file named BatchGetTraversableTest to cover the usage of batch operations for managing contacts. Also updated the CHANGELOG to include the fix regarding the limit argument not working in batch list and read model. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
A new path to the Core directory was added to the Rector configuration. This ensures that our Rector tool can identify and manage code within this new directory. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
In this commit, code clarity and efficiency have been improved across several classes. Unnecessary comments and excessive lines of code have been removed. Additionally, all the constructors and property assignments have been updated to use PHP 7.4 syntax, which provides a more concise way to declare and initialize class properties. In some places, the error messages have been updated to be more descriptive. Finally, the conditionals and the loop iterations have been optimized for better performance. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
This commit focuses on restructuring DTO classes to improve readability and efficiency. Specific changes include making classes read-only, reducing unnecessary lines of code and using concise property promotion in the constructor parameters. The refactored classes include Time, ResponseData, Pagination, RenewedAccessToken, and Response. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
The 'order' parameter in Batch.php was updated to be populated with the $order variable, previously it was initiated as an empty array. This change accommodates more specific sorting requirements in batch operations. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Integration tests have been added for the Core component. The Makefile and phpunit.xml.dist files were updated to reflect these new tests. Further, exceptions in CoreTest.php and Core.php have been adjusted to better handle Transport and Json exceptions. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
The Credentials constructor has been simplified by removing redundant comments and checks. Error checking has been improved - it now ensures that either an AccessToken or WebhookUrl must be set for authentication. The code readability has also been enhanced by removing the full namespace from instance checks, using the imported class names instead. A minor change was also made in the Batch.php file to enhance code formatting. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new test file named BatchGetTraversableTest to cover the usage of batch operations for managing contacts. Also updated the CHANGELOG to include the fix regarding the limit argument not working in batch list and read model.