Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BatchGetTraversableTest and update CHANGELOG #394

Commits on Jun 29, 2024

  1. Add BatchGetTraversableTest and update CHANGELOG

    Added a new test file named BatchGetTraversableTest to cover the usage of batch operations for managing contacts. Also updated the CHANGELOG to include the fix regarding the limit argument not working in batch list and read model.
    
    Signed-off-by: mesilov <mesilov.maxim@gmail.com>
    mesilov committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    8ba6792 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Add Core directory to Rector paths

    A new path to the Core directory was added to the Rector configuration. This ensures that our Rector tool can identify and manage code within this new directory.
    
    Signed-off-by: mesilov <mesilov.maxim@gmail.com>
    mesilov committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    f739ac3 View commit details
    Browse the repository at this point in the history
  2. Refactor code for better clarity and efficiency

    In this commit, code clarity and efficiency have been improved across several classes. Unnecessary comments and excessive lines of code have been removed. Additionally, all the constructors and property assignments have been updated to use PHP 7.4 syntax, which provides a more concise way to declare and initialize class properties. In some places, the error messages have been updated to be more descriptive. Finally, the conditionals and the loop iterations have been optimized for better performance.
    
    Signed-off-by: mesilov <mesilov.maxim@gmail.com>
    mesilov committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    0d3537a View commit details
    Browse the repository at this point in the history
  3. Refactor DTO classes, optimizing methods and properties

    This commit focuses on restructuring DTO classes to improve readability and efficiency. Specific changes include making classes read-only, reducing unnecessary lines of code and using concise property promotion in the constructor parameters. The refactored classes include Time, ResponseData, Pagination, RenewedAccessToken, and Response.
    
    Signed-off-by: mesilov <mesilov.maxim@gmail.com>
    mesilov committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    9c6c4fa View commit details
    Browse the repository at this point in the history
  4. Update 'order' array population in Batch.php

    The 'order' parameter in Batch.php was updated to be populated with the $order variable, previously it was initiated as an empty array. This change accommodates more specific sorting requirements in batch operations.
    
    Signed-off-by: mesilov <mesilov.maxim@gmail.com>
    mesilov committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    81be564 View commit details
    Browse the repository at this point in the history
  5. Add integration tests for Core and update exceptions

    Integration tests have been added for the Core component. The Makefile and phpunit.xml.dist files were updated to reflect these new tests. Further, exceptions in CoreTest.php and Core.php have been adjusted to better handle Transport and Json exceptions.
    
    Signed-off-by: mesilov <mesilov.maxim@gmail.com>
    mesilov committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    5811210 View commit details
    Browse the repository at this point in the history
  6. Refactor Credentials constructor and simplify code

    The Credentials constructor has been simplified by removing redundant comments and checks. Error checking has been improved - it now ensures that either an AccessToken or WebhookUrl must be set for authentication. The code readability has also been enhanced by removing the full namespace from instance checks, using the imported class names instead. A minor change was also made in the Batch.php file to enhance code formatting.
    
    Signed-off-by: mesilov <mesilov.maxim@gmail.com>
    mesilov committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    22871a0 View commit details
    Browse the repository at this point in the history