Skip to content

Conversation

@lazka
Copy link
Contributor

@lazka lazka commented Jul 13, 2024

by forcing an older nodejs

the node v20 build no longer works in bionic. While actions/checkout@v3 uses node v16 GHA forced it to use v20 some time ago after a deprecation cycle. This env var makes it use v16 again, despite that being EOL.

by forcing an older nodejs
@lazka lazka requested a review from jpakkane as a code owner July 13, 2024 12:27
@jpakkane
Copy link
Member

Bionic has been EOL since 2023-05-31. I'd say let's move that container to Focal instead.

@eli-schwartz
Copy link
Member

Bionic currently tests that we maintain support for Python 3.7 (and I don't want to bump the minimum version of python until we are using features that require the new version -- we still occasionally get complaints that meson dropped 3.6 support but I spearheaded that upgrade because of tangible developer advantages in moving to 3.7, not just "GitHub broke the CI so we don't test it").

Beyond that, I saw at least one claim that the GitHub Actions nodejs issue affects Ubuntu 20.04 (focal) containers as well, but I haven't verified.

@lazka
Copy link
Contributor Author

lazka commented Jul 15, 2024

Fine with me either way. This makes the CI green though in the meantime.

@lazka
Copy link
Contributor Author

lazka commented Jul 15, 2024

A middle ground could be Debian Buster, Python 3.7, newer glibc, EOL since two weeks.

@dcbaker
Copy link
Member

dcbaker commented Jul 15, 2024

In the interest of having a green CI, I'm going to merge this. If we want to move to Focal or Buster we can do that as a separate PR

@dcbaker dcbaker merged commit 9cc94a1 into mesonbuild:master Jul 15, 2024
@lazka
Copy link
Contributor Author

lazka commented Jul 15, 2024

thanks!

@eli-schwartz eli-schwartz added this to the 1.5.1 milestone Jul 26, 2024
nirbheek added a commit to nirbheek/meson that referenced this pull request Jul 26, 2024
nirbheek added a commit that referenced this pull request Jul 30, 2024
Keep using v3 for Bionic because of #13424
serebit pushed a commit to serebit/meson that referenced this pull request Feb 19, 2025
Volker-Weissmann pushed a commit to Volker-Weissmann/meson that referenced this pull request May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants