Fix some CI summary deprecation warnings #13474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At the time, I had discovered it kinda doesn't work, because updating to node 20 broke the os_comp tests. I never got around to redesigning them to free us of the oppression of github's action versions running inside arbitrary containers with older glibcs. And then just recently that hit us again. :) |
|
The CI results are in -- this breaks the workaround introduced in #13424. |
|
Hm, so we need to still use older node with the bionic job at least. |
Keep using v3 for Bionic because of mesonbuild#13424
|
Now the only things left to update are checkout (for bionic) and codecov (because there's a breaking change) |
|
No new build failures fwict, ok to merge @eli-schwartz? |
|
Will merge this in 24h if there are no objections. I have manually verified that the CI failures are not new. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supposedly, breakage will happen in a few months.